Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link https://github.com/testing-library/user-event/blob/main/README.md#keyboardtext-options is broken #876

Closed
joshunger opened this issue Mar 4, 2022 · 5 comments · Fixed by #881
Closed

Link https://github.com/testing-library/user-event/blob/main/README.md#keyboardtext-options is broken #876

joshunger opened this issue Mar 4, 2022 · 5 comments · Fixed by #881
Labels
bug Something isn't working released on @beta
Milestone
userEvent v14

Comments

@joshunger
Copy link

Reproduction example

N/A

Prerequisites

N/A

Expected behavior

N/A

Actual behavior

N/A

User-event version

13.5.0

Environment

Testing Library framework:

JS framework:

Test environment:

DOM implementation:

Additional context

The link specified on

user-event/src/utils/keyDef/readNextDescriptor.ts

Line 136 in e2a5f43

See https://github.com/testing-library/user-event/blob/main/README.md#keyboardtext-options
doesn't work for me. I was going to submit a PR but I don't know the correct URL?
@joshunger joshunger added bug Something isn't working needs assessment This needs to be looked at by a team member labels Mar 4, 2022
@ph-fritsche
Copy link
Member

The input format is described in
https://testing-library.com/docs/user-event/keyboard for keyboard()
and
https://testing-library.com/docs/user-event/pointer#pressing-a-button-or-touching-the-screen for pointer().

@ph-fritsche ph-fritsche removed the needs assessment This needs to be looked at by a team member label Mar 4, 2022
@joshunger
Copy link
Author

joshunger commented Mar 5, 2022 •
edited
Loading

Just pointed it to the keyboard article 👍 #877

@ph-fritsche ph-fritsche added this to the userEvent v14 milestone Mar 21, 2022
@ph-fritsche ph-fritsche mentioned this issue Mar 24, 2022
Merged
2 tasks
@ph-fritsche
Copy link
Member

@all-contributors add @joshunger bug

@allcontributors allcontributors bot mentioned this issue Mar 24, 2022
Merged
@allcontributors
Copy link
Contributor

@ph-fritsche

I've put up a pull request to add @joshunger! 🎉

@github-actions
Copy link

🎉 This issue has been resolved in version 14.0.0-beta.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released on @beta
Projects
None yet
Milestone
userEvent v14
Development

Successfully merging a pull request may close this issue.

fix: log correct docs link for invalid key descriptors testing-library/user-event
2 participants
@joshunger @ph-fritsche