fix: replace pointer implementations #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1ffc0b1:
|
Codecov Report
@@ Coverage Diff @@
## userEvent14 #754 +/- ##
==============================================
Coverage 100.00% 100.00%
==============================================
Files 50 65 +15
Lines 965 1245 +280
Branches 389 469 +80
==============================================
+ Hits 965 1245 +280
Continue to review full report at Codecov.
|
ph-fritsche
added a commit
that referenced
this pull request
Oct 21, 2021
* add dblclick event * add `pointerId` and `pointerType` to `click` * bind APIs to userEvent instance * no mouse events on disabled elements * fix which elements bubble * replace hover implementation * fix events on disabled elements * fix button * fix buttons * replace click * remove unused utils * branch coverage BREAKING CHANGE: The implementation of pointer related APIs was replaced. This might break tests relying on unintended side-effects of the previous implementation.
ph-fritsche
added a commit
that referenced
this pull request
Nov 28, 2021
* add `pointerId` and `pointerType` to `click` BREAKING CHANGE: The implementation of pointer related APIs was replaced. This might break tests relying on unintended side-effects of the previous implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Replace implementations of our pointer related APIs with calls to
pointer.Why:
One API to rule them all.
We still have a lot of workarounds scattered over the different implementations.
Replacing the previous implementations with our generalized approach in
pointerhighlights when the results of the new implementation differ. Sometimespointerneeds more work, sometimes the previous assumptions were wrong.Checklist:
Non-trivial changes to the previous implementation
(aside added data like
pointerIdetc.)*enter/*leaveis not applied on every element in the tree.Misinterpretation of the following spec?