-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Node 10 support #681
Comments
Why would you consider this a breaking change? |
We promise to support Node 10 in "engines": {
"node": ">=10"
} If I remember correctly, Yarn fails builds on engine mismatch by default. This is therefore a breaking change for Yarn users on Node 10, and also any npm users that manually enable |
Would it be reasonable to remove the |
I feel like that would imply we're still supporting Node 10, which we're not really, since we already disabled it within CI in #685. Semver minor releases are supposed to be fully back compatible, so not saying we will try to support Node 10 is a breaking change, even if Node 10 still works, IMO. If you want us to continue supporting Node 10 explicitly, we could revert these PRs, but that could still prevent users from upgrading DOM Testing Library and React Testing Library.
True, but the Node version still affects other things we depend on such as JavaScript syntax and other feature support. Most browsers update themselves automatically so I feel like this is less of an issue with supporting browsers anyway. Overall I think it's still a good idea for us to use |
Because it's EOL.
The text was updated successfully, but these errors were encountered: