Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing keys ([Enter], [ArrowDown], etc.) does not work in antd select combobox input. #1137

Open
karoAlfa opened this issue May 24, 2023 · 4 comments
Labels
bug Something isn't working needs assessment This needs to be looked at by a team member

Comments

@karoAlfa
Copy link

Reproduction example

https://codesandbox.io/s/selectcombobox-test-nhch9c

Prerequisites

  1. Use antd components library.
  2. Render Select component with some options.
  3. In the test get element by role 'combobox' (const input = screen.getByRole('combobox');)
  4. Focus on the element (await user.click(input)).
  5. In the keyboard type ArrowDown, ArrowDown, Eneter (await user.keyboard('[ArrowDown][ArrowDown][Enter]')).

Expected behavior

One of the options should be selected, and therefore handleChange function should be triggered.

Actual behavior

The handleChange function is not triggered at all.

User-event version

14.4.3

Environment

Testing Library framework: @testing-library/[email protected]

JS framework: [email protected]

Test environment: [email protected]

Antd library: [email protected]

Additional context

Recently, I've decided to upgrade my user-event package from 13.5.0 to 14. I have not had problems migrating tests with buttons, numeric input, and text inputs. But for some reason, combobox input behaves differently, and it looks like I can not use function keys on it such as ArrowDown, Enter, etc. It is worth mentioning that in the previous version (before 14), user-event worked perfectly fine with Select components from antd library.

@karoAlfa karoAlfa added bug Something isn't working needs assessment This needs to be looked at by a team member labels May 24, 2023
@KrDimitrov
Copy link

KrDimitrov commented May 24, 2023

Seems to be happening with KendoReact's combobox as well as Datepicker as well

@KumarDavinder
Copy link

KumarDavinder commented Aug 25, 2023

I am having the same issue and do not know how to fix it. I passed from userEvent v13.5.0 to v14.4.3.

@kapiljaveri
Copy link

event.which seems to have gotten deprecated - #842 (comment) and is not filled out any more.

antd relies on this all over their code-base, which is why this doesn't work with v14.

https://github.com/search?q=repo%3Areact-component%2Fselect%20which&type=code

@coltanium13
Copy link

coltanium13 commented Sep 18, 2023

Am i understanding it correctly that the KeyboardEvent.code for 'Enter' is still just keyboard('[Enter]'), that is the KeyboardEvent.code right?

What does it mean that you should use KeyboardEvent.code instead, does that mean use the keyboard('[Enter]') bracket syntax?

i also have this discussion question out:
#1164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs assessment This needs to be looked at by a team member
Projects
None yet
Development

No branches or pull requests

5 participants