-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support code view highlight in Recorder #33
Comments
@nickmccurdy fyi! |
Thanks, this looks like it would be handy! Is there any implementation documentation or code sample for it yet? |
Hi Nick, it will work once you upgrade the @puppeteer/replay dependency in this project and rebuild. There's no extra implementation needed. To see how we build it, this is the code: https://github.com/puppeteer/replay/blob/main/src/stringify.ts#L68 |
Is this a side effect of importing the library or do I need to call |
@nickmccurdy source maps get added by the stringify function and you already call it https://github.com/testing-library/testing-library-recorder-extension/blob/main/src/RecorderPlugin.ts#L13 so no changes in the code are needed (only need to update to the latest replay version). |
Ah, I got confused because I forgot about how the extension gets registered, thanks! |
Chrome 110 launches a new "Show code and highlight" feature.
How to test
You can test this feature with the latest Chrome Canary
Action required
If your extension doesn't have Puppeteer Replay as dependency, you can implement the [sourcemaps] (https://github.com/puppeteer/replay/blob/main/src/stringify.ts#L68) yourself to make it work.
my gif has pretty low res.
The text was updated successfully, but these errors were encountered: