fix(prefer-to-have-style): do not offer invalid autofix for computed accessors

[G-Rath]

What:

Changes prefer-to-have-style to not give an autofix if a variable is being used to access style.

Why:

Because it generates an invalid autofixer.

Note that we could probably do at least a suggestion (or two), but at this point I'm not too sure of the semantics and currently this is creating invalid code - if someone wants to do a followup PR that improves this rule, I'd be happy to review it.

How:

By not setting fix if the node is an Identifier.

Checklist:

• Documentation
• Tests
• Ready to be merged
  

Resolves #265
Resolves #286

(note I've purposely not formatted my code to test a theory)

[codecov]

Codecov Report

Merging #306 (547d68f) into main (96c364a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #306   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          581       584    +3     
  Branches       165       168    +3     
=========================================
+ Hits           581       584    +3     

Impacted Files	Coverage Δ
src/rules/prefer-to-have-style.js	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[G-Rath]

@MichaelDeBoey fyi I'm pretty sure that kcd-scripts lint is doing absolutely nothing, so neither eslint or prettier is being properly run against this repo.

[MichaelDeBoey]

@G-Rath Would you be able to look into the problem?

[G-Rath]

@MichaelDeBoey ideally no as I'm not really a big proponent for these sort of things, but I can spend a couple of minutes digging to at least try to make an issue if not a PR.

[github-actions]

🎉 This PR is included in version 5.0.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[G-Rath]

@MichaelDeBoey ok so it looks like linting is working, it just doesn't run prettier - I think you'll need to take it from here because it looks like eslint-config-kentcdodds is outright missing eslint-plugin-prettier even though it has eslint-config-prettier, and I don't know if that's intentional or if there will need to be any other changes or what.