fix(prefer-to-have-value): check that property exists before accessing (

#243) Co-authored-by: Ben Monro <[email protected]>
testing-library · Dec 26, 2021 · 3f59068 · 3f59068
1 parent e8cefd3
commit 3f59068
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/__tests__/lib/rules/prefer-to-have-value.js b/src/__tests__/lib/rules/prefer-to-have-value.js
@@ -52,6 +52,10 @@ ruleTester.run("prefer-to-have-value", rule, {
 
     `const element = { value: 'foo' };
     expect(element.value).not.toBe('foo');`,
+    `
+      const res = makePath()();
+      expect(res.value).toEqual('/repositories/create');
+    `,
   ],
   invalid: [
     {

diff --git a/src/assignment-ast.js b/src/assignment-ast.js
@@ -74,7 +74,9 @@ export function getQueryNodeFrom(context, nodeWithValueProp) {
     };
   }
 
-  const query = queryNode.callee.name || queryNode.callee.property.name;
+  const query =
+    queryNode.callee.name ||
+    (queryNode.callee.property && queryNode.callee.property.name);
   const queryArg = queryNode.arguments[0] && queryNode.arguments[0].value;
   const isDTLQuery = queries.includes(query);