Merge pull request #408 from grosser/grosser/symbols

enforce :"foo-bar" over :'foo-bar' to be consistent with other doubl…
standardrb · Apr 26, 2022 · 61f0c0a · 61f0c0a
2 parents e6130ac + 1ec52c6
commit 61f0c0a
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 1 deletion.
diff --git a/config/base.yml b/config/base.yml
@@ -1561,7 +1561,8 @@ Style/Proc:
   Enabled: true
 
 Style/QuotedSymbols:
-  Enabled: false
+  Enabled: true
+  EnforcedStyle: same_as_string_literals
 
 Style/RaiseArgs:
   Enabled: false

diff --git a/test/fixture/quoted_symbols/.standard.yml b/test/fixture/quoted_symbols/.standard.yml
diff --git a/test/fixture/quoted_symbols/test.rb b/test/fixture/quoted_symbols/test.rb
@@ -0,0 +1,3 @@
+a = :"good-d"
+b = :'bad-d'
+puts a + b
diff --git a/test/standardrb_test.rb b/test/standardrb_test.rb
@@ -32,6 +32,14 @@ def test_project_with_cwd_in_nested_path
     MSG
   end
 
+  def test_quoted_symbols_are_enforced
+    stdout, status = run_standardrb("test/fixture/quoted_symbols")
+    refute status.success?, stdout
+    assert_equal stdout.scan(/.*\.rb.*/), [
+      "  test.rb:2:5: Style/QuotedSymbols: Prefer double-quoted symbols unless you need single quotes to avoid extra backslashes for escaping."
+    ]
+  end
+
   private
 
   def run_standardrb(cwd, args = [])