Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revive builtIn scripts resolver #58

Closed
texastoland opened this issue Jul 25, 2018 · 2 comments
Closed

Revive builtIn scripts resolver #58

texastoland opened this issue Jul 25, 2018 · 2 comments

Comments

@texastoland
Copy link
Contributor

texastoland commented Jul 25, 2018

You removed builtIn scripts in 17520b5. It'd be useful in my project to expose base scripts that dependent packages can override (I'll summarize better when it's not so late). It would only require changing 1) builtIn scripts to be resolved relative to node_modules and 2) add an option named something like preset.

@searls
Copy link
Member

searls commented Jul 26, 2018

I'm open to this so long as it can be accomplished in a way that absolutely does not cause anyone's existing scripty use to accidentally invoke a shared script or for some bad actor to cleverly trigger a script by a scripty user. Arbitrary script execution of stuff in your node_modules (e.g. postinstall security fiascos) is appropriately scary enough as it is.

@texastoland
Copy link
Contributor Author

texastoland commented Jul 26, 2018

I'll PR today. It's as safe as configuring path. The idea is to run default scripts from a specified "preset" package but still create your own locally. Kind of the way create-react-app works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants