Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PNPM Support #115

Open
davemo opened this issue Nov 29, 2022 · 3 comments
Open

PNPM Support #115

davemo opened this issue Nov 29, 2022 · 3 comments

Comments

@davemo
Copy link

davemo commented Nov 29, 2022

For the most part scripty works just fine with pnpm, the only difference I've run into is the forwarding of command-line arguments does not work.

I suspect this is because with npm you have to explicitly use the -- to forward arguments, and with pnpm you do not.

I can submit a PR if you can point me in the right direction @jasonkarns - it wasn't obvious to me which part of the codebase I'd need to make a change in to support this 🤓

@davemo
Copy link
Author

davemo commented Nov 29, 2022

Seems it might be necessary to invoke a different lifecycle hook method 🤔 https://github.com/pnpm/pnpm/tree/main/exec/lifecycle#readme

@searls
Copy link
Member

searls commented Dec 2, 2022

Thanks for raising this @davemo -- would welcome a PR! I haven't actually used scripty for several years or else I'd try to figure this out

@jasonkarns
Copy link
Member

I would almost argue that pnpm should accept -- to separate pnpm args from its script args. That's a longstanding unix convention; even in cases where the -- is optional, it's still allowed. Not that scripty couldn't work around it, but seems a worthwhile feature request to pnpm anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants