Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to build the docker containers before starting #76

Closed
jtanios opened this issue Mar 21, 2020 · 3 comments
Closed

Option to build the docker containers before starting #76

jtanios opened this issue Mar 21, 2020 · 3 comments

Comments

@jtanios
Copy link

jtanios commented Mar 21, 2020

When using this package to test a custom container, it'd be good to build the containers before starting the service every time the test runs to make sure any new changes to the Dockerfiles are tested.

I think this can be a param to the DockerCompose constructor:
def __init__(self, filepath, compose_file_name="docker-compose.yml", build=False):

If True, it would add a --build option to the docker-compose command inside start()

@tillahoffmann
Copy link
Collaborator

That sounds like a good idea. Fancy sending a PR?

@jtanios
Copy link
Author

jtanios commented Mar 23, 2020

That sounds like a good idea. Fancy sending a PR?

Sure, I'll submit one pretty soon.

@tillahoffmann
Copy link
Collaborator

Closing for now as wontfix (see #83 for details), but thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants