diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 12c8d19f..1b1f6b92 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -39,7 +39,7 @@ You need to have the following tools available to you: ## Adding new containers -We have an [issue template](.github/ISSUE_TEMPLATE/new-container.md) for adding new containers, please refer to that for more information. +We have an [issue template](./ISSUE_TEMPLATE/new-container.md) for adding new containers, please refer to that for more information. Once you've talked to the maintainers (we do our best to reply!) then you can proceed with contributing the new container. > [!WARNING] diff --git a/modules/vault/testcontainers/vault/__init__.py b/modules/vault/testcontainers/vault/__init__.py index 5f50cdd4..c89b27ea 100644 --- a/modules/vault/testcontainers/vault/__init__.py +++ b/modules/vault/testcontainers/vault/__init__.py @@ -12,6 +12,7 @@ # under the License. from http.client import HTTPException +from urllib.error import URLError from urllib.request import urlopen from testcontainers.core.container import DockerContainer @@ -61,7 +62,7 @@ def get_connection_url(self) -> str: exposed_port = self.get_exposed_port(self.port) return f"http://{host_ip}:{exposed_port}" - @wait_container_is_ready(HTTPException) + @wait_container_is_ready(HTTPException, URLError) def _healthcheck(self) -> None: url = f"{self.get_connection_url()}/v1/sys/health" with urlopen(url) as res: