-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change docker command of cockroachDB module #3608
Conversation
Issue: testcontainers#3571 This also includes changing default tag version (to v19.2.11)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EDIT: accidentally clicked the approve button 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to be problematic - it will mean that people who are using the default constructor in their tests will suddenly receive a different version of the container.
This is outlined further in #3381.
Also, we'll have a problem if start-single-node
is not backwards compatible with older versions if CockroachDB. We can't break peoples' tests if they explicitly need to use older versions. Is it backwards compatible?
@rnorth Since this module is incubating module, I thought this change is acceptable. Thanks for your review. |
@rnorth given the deprecated version and default tag being changed, I think we're good to go :) Will merge :) Note that old versions can still be used by overriding the command, so we're not blocking the usage of them, just raising the minimal version requirement (again, since v19.1.x is EOL) |
@bsideup |
This PR resolves #3571
Caveat
v19.1.x
version,start-single-node
command does not work.