You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Apparently since the transition to build with gradle, com.google.code.findbugs:jsr305 has been on the compile classpath for consumers of testcontainers-java.
My goal is to get jsr305 off the classpath for consumers to reduce the chance for conflicts (with e.g. com.google.code.findbugs:annotations). One way appears to be switching it to a compileOnly dependency (#913). Another way would be to ditch the @Nullable annotations, though if they're adding value, let's keep 'em.
There's also this from guava: google/guava#2960 about them ditching jsr305 one day. I can't say I've totally grasped all the issues, nor what the ideal replacement (if any) for testcontainers would be. Here's a PR to remove @Nullable and the dependency on jsr305 though: #920.
Apparently since the transition to build with gradle, com.google.code.findbugs:jsr305 has been on the compile classpath for consumers of testcontainers-java.
From what I can tell, we only need it here for the
@Nullable
annotations in OkHttpInvocationBuilder.java.My goal is to get jsr305 off the classpath for consumers to reduce the chance for conflicts (with e.g. com.google.code.findbugs:annotations). One way appears to be switching it to a compileOnly dependency (#913). Another way would be to ditch the
@Nullable
annotations, though if they're adding value, let's keep 'em.Got some inspiration from google/guava#1018 (comment).
The text was updated successfully, but these errors were encountered: