Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Hold open a connection to ryuk during a call to Up #2621

Open
maxmzkr opened this issue Jul 2, 2024 · 2 comments
Open

[Feature]: Hold open a connection to ryuk during a call to Up #2621

maxmzkr opened this issue Jul 2, 2024 · 2 comments
Labels
feature New functionality or new behaviors on the existing one

Comments

@maxmzkr
Copy link

maxmzkr commented Jul 2, 2024

Problem

When using the compose module and the services take a bit to start up, the ryuk container will timeout and close during the call to Up.

Examples in #2618 #2563

Solution

Hold a connection to the ryuk container during the lifetime of the Up call.

Benefit

More complex or longer start up time docker compose files will be able to start without requiring users to set higher timeout configurations.

Alternatives

Increasing the ryuk connection/reconnect timeouts. This would help, but it requires every runner of the test to know to set the higher timeout. Because we know we don't want to close the ryuk container while Up is being run, it makes sense to make it work without the need for configuration changes.

Would you like to help contributing this feature?

Yes

@maxmzkr maxmzkr added the feature New functionality or new behaviors on the existing one label Jul 2, 2024
@maxmzkr
Copy link
Author

maxmzkr commented Jul 2, 2024

Following a chain from here #2618

@stevenh
Copy link
Collaborator

stevenh commented Aug 6, 2024

This is fixed by the changes in #2664

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality or new behaviors on the existing one
Projects
None yet
Development

No branches or pull requests

2 participants