Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opened PR: Contributing Docs need an update based on error logs #260

Closed
shashank-g172 opened this issue Oct 26, 2020 · 1 comment
Closed

Comments

@shashank-g172
Copy link
Contributor

Describe the bug
While attempting to build the container locally while adding a new feature, I noticed that that the contributing.md doc needs an update to a later version of go, but I'm not sure how that'll break Travis builds.

To Reproduce
Run the steps on the docs once exec'd into the container

Expected behavior
No build errors

** docker info **
Command> go vet ./...
output of the command:
/root/go/pkg/mod/github.com/containerd/[email protected]/errdefs/errors.go:92:9: undefined: "github.com/pkg/errors".Is

github.com/testcontainers/testcontainers-go/wait

wait/http.go:154:3: unknown field 'ForceAttemptHTTP2' in struct literal of type http.Transport
wait/http.go:185:16: undefined: http.NewRequestWithContext
note: module requires Go 1.13# github.com/docker/docker/pkg/archive
/root/go/pkg/mod/github.com/docker/[email protected]+incompatible/pkg/archive/archive_linux.go:155:18: undefined: strings.ReplaceAll
/root/go/pkg/mod/github.com/docker/[email protected]+incompatible/pkg/archive/archive_linux.go:242:18: undefined: strings.ReplaceAll

github.com/testcontainers/testcontainers-go/wait [github.com/testcontainers/testcontainers-go/wait.test]

wait/http.go:154:3: unknown field 'ForceAttemptHTTP2' in struct literal of type http.Transport
wait/http.go:185:16: undefined: http.NewRequestWithContext

$ docker info
docker --version
Docker version 18.06.1-ce, build e68fc7a

Additional context

@shashank-g172 shashank-g172 changed the title Contributing Docs need an update based on error logs Opened PR: Contributing Docs need an update based on error logs Nov 3, 2020
@mdelapenya
Copy link
Member

@shashank-g172 I'm still not able to reproduce this is issue, so I'm closing it now.

Please feel free to reopen it if you are still seeing what's described here

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants