Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consul: Update wait strategy #2335

Closed
mdelapenya opened this issue Mar 8, 2024 · 1 comment · Fixed by #2336
Closed

consul: Update wait strategy #2335

mdelapenya opened this issue Mar 8, 2024 · 1 comment · Fixed by #2336

Comments

@mdelapenya
Copy link
Member 

          note this introduced a flake. The former example was waiting for the listen port (as are most ad-hoc usages on github). This passes before the api is ready failing tests. I think it should be reverted to what the example used:

		testcontainers.WithWaitStrategy(wait.ForListeningPort("8500/tcp")),

Originally posted by @codefromthecrypt in #2194 (comment)
@codefromthecrypt codefromthecrypt mentioned this issue Mar 8, 2024
Merged
@codefromthecrypt
Copy link
Contributor

#2336

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: consul race on HTTP port codefromthecrypt/testcontainers-go
2 participants
@codefromthecrypt @mdelapenya