Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default velocity/acceleration/effort values in trajectory conversion utility #84

Open
marip8 opened this issue Dec 13, 2023 · 0 comments

Comments

@marip8
Copy link
Contributor

marip8 commented Dec 13, 2023

When converting tesseract trajectories to ROS trajectories, we automatically fill in velocities, accelerations, and efforts with default values (0), even if the tesseract trajectory doesn't have values for those quantities.

current_point.velocities = std::vector<double>(joint_names.size(), 0);
current_point.accelerations = std::vector<double>(joint_names.size(), 0);
current_point.effort = std::vector<double>(joint_names.size(), 0);

This causes problems with the latest version of ros2_control which expects only the quantities that are used to control the trajectory to be in the trajectory. For example, the joint_trajectory_controller will reject a trajectory where an all-zero vector of efforts is specified and the joint does not have an effort control interface. If we are not calculating velocity, acceleration, and/or effort, we shouldn't populate default values into the trajectory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant