-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean build warnings #584
Comments
Similar warnings can be produced on Linux using clang++. But even the default debug build with gcc produces tons of warnings (mainly signed/unsigned mismatch). |
I've also removed /W1 (warning level 1, default is 3) in leptonica for MSVC. |
In leptonica:
|
What do you think? |
Mixing float and double can result in additional code (and execution time) for conversions between both types. |
Any program may do a few tens of these, so we're talking about a small fraction of a microsecond. Eliminating these windows compiler warnings is not high on my todo list. I'll try to remember to add "f" to numbers in files that I'm modifying for other reasons. |
Closing this, because more info is provided in #1036 |
Currently we see tons of warnings during MSVC builds.
They should be fixed during
modernizing code
phase.See this log for warnings https://ci.appveyor.com/api/buildjobs/3v0vmv6xjy658f79/log
The text was updated successfully, but these errors were encountered: