Don't trigger a deliberate SIGSEGV for fatal errors in release code

The error message "segmentation fault" confuses most users, so enforce a segmentation fault only in debug code. Release code simply calls the abort function. Signed-off-by: Stefan Weil <[email protected]>
tesseract-ocr · Sep 20, 2018 · 5338a5a · 5338a5a
1 parent cefb62b
commit 5338a5a
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/ccutil/errcode.cpp b/src/ccutil/errcode.cpp
@@ -71,17 +71,20 @@ const char *format, ...          // special message
   // %s is needed here so msg is printed correctly!
   fprintf(stderr, "%s", msg);
 
-  int* p = nullptr;
   switch (action) {
     case DBG:
     case TESSLOG:
       return;                    //report only
     case TESSEXIT:
       //err_exit();
     case ABORT:
+#if !defined(NDEBUG)
       // Create a deliberate segv as the stack trace is more useful that way.
-      if (!*p)
-        abort();
+      // This is done only in debug builds, because the error message
+      // "segmentation fault" confuses most normal users.
+      *reinterpret_cast<int*>(0) = 0;
+#endif
+      abort();
     default:
       BADERRACTION.error ("error", ABORT, nullptr);
   }