Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routeros_capsman_provisioning: incorrect datatypes for some properties #551

Closed
dsbibby opened this issue Aug 31, 2024 · 1 comment
Closed
Labels

Comments

@dsbibby
Copy link

dsbibby commented Aug 31, 2024

Describe the bug
The following properties of the routeros_capsman_provisioning resource are currently defined as string but should be list(string):

  • hw_supported_modes
  • ip_address_ranges
  • slave_configurations

This is particularly troublesome for the hw_supported_modes field as it is constrained to allow only ["a" "a-turbo" "ac" "an" "b" "g" "g-turbo" "gn"] but in actually ROS allows lists to be defined, e.g. ac,an

To Reproduce
Try passing ac,an as a value to hw_supported_modes - it will raise an error: expected hw_supported_modes to be one of ["a" "a-turbo" "ac" "an" "b" "g" "g-turbo" "gn"], got ac,an

Expected behavior
Each of the above properties should allow lists of strings to be passed.

@dsbibby dsbibby added the bug Something isn't working label Aug 31, 2024
@vaerh vaerh closed this as completed in b9967d9 Sep 2, 2024
@vaerh
Copy link
Collaborator

vaerh commented Sep 2, 2024

🎉 This issue has been resolved in version 1.61.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@vaerh vaerh added the released label Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants