Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabled mangle not seen #175

Closed
n0rad opened this issue Apr 14, 2023 · 5 comments
Closed

disabled mangle not seen #175

n0rad opened this issue Apr 14, 2023 · 5 comments
Assignees
Labels
bug Something isn't working released

Comments

@n0rad
Copy link

n0rad commented Apr 14, 2023

resource "routeros_ip_firewall_mangle" "preroute_mark_conn_11" {
  chain               = "prerouting"
  in_interface        = "isp11"
  connection_state    = "new"
  action              = "mark-connection"
  new_connection_mark = "isp11_conn"
}

go Disable the rule on the router -> plan is empty

@n0rad n0rad added the bug Something isn't working label Apr 14, 2023
@vaerh
Copy link
Collaborator

vaerh commented Apr 17, 2023

I need some time to think about what to do about this behavior. Perhaps I should have written that the provider was built on the assumption of a single control point - only terraform.

@n0rad
Copy link
Author

n0rad commented Apr 17, 2023

Perhaps I should have written that the provider was built on the assumption of a single control point - only terraform.

Which is fair, but you know in case of emergency you could go to the mikrotik directly and disable some stuff, and then will be lost in the convergence.

Actually it's working ok as soon as you add the disabled flags to all rules so I did. but my guess is that it should be seen as enabled by default if the flag is not set.

@vaerh
Copy link
Collaborator

vaerh commented Apr 17, 2023

I agree, there needs to be some changes and a lot of testing, since this flag is included in almost all resources.
I also take pause for implementation!

@vaerh vaerh self-assigned this Apr 20, 2023
@vaerh vaerh closed this as completed in ffb53d6 Apr 20, 2023
@gfenn-newbury
Copy link
Collaborator

🎉 This issue has been resolved in version 1.3.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@n0rad
Copy link
Author

n0rad commented Apr 20, 2023

Tested on nat and mangle, working perfectly! Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

No branches or pull requests

3 participants