Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for vSAN performance service configuration #1727

Closed
4 tasks done
SlimYang opened this issue Aug 9, 2022 · 1 comment · Fixed by #1726
Closed
4 tasks done

Add support for vSAN performance service configuration #1727

SlimYang opened this issue Aug 9, 2022 · 1 comment · Fixed by #1726
Assignees
Labels
acknowledged Status: Issue or Pull Request Acknowledged area/clustering Area: Clustering enhancement Type: Enhancement size/l Relative Sizing: Large
Milestone

Comments

@SlimYang
Copy link
Collaborator

SlimYang commented Aug 9, 2022

Community Guidelines

  • I have read and agree to the HashiCorp Community Guidelines .
  • Vote on this issue by adding a 👍 reaction to the original issue initial description to help the maintainers prioritize.
  • Do not leave "+1" or other comments that do not add relevant information or questions.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Description

Currently, Terraform vSphere provider supports the configuration for vSAN for toggling its enablement state and the dedupe/compression. We need to close the gap to enable other critical vSAN services/features like performance service, unmap, file service, etc. Therefore, I created this ticket to track the feature request to enable vSAN performance service.

Use Case(s)

This is to support the configuration for vSAN performance service enabling, together with the enablement for the network diagnsotics mode and the verbose mode which is under the section for vSAN performance configuration. We have already got the vSAN UI and API support for this feature, so it worth looking at the Terraform support which can automate this process as well.

Potential Terraform Provider Configuration

resource "vsphere_compute_cluster" "cluster" {
   name = "clustername"
   datacenter_id = data.vsphere_datacenter.datacenter.id
   vsan_enabled = true
   vsan_performance_enabled = false
   vsan_network_diagnostic_mode_enabled = true
   vsan_verbose_mode_enabled = true
}

References

Related pull request: #1726

@SlimYang SlimYang added the enhancement Type: Enhancement label Aug 9, 2022
@tenthirtyam tenthirtyam changed the title Add support for configuring vSAN performance service Add support for vSAN performance service configuration Aug 9, 2022
@tenthirtyam tenthirtyam added this to the v2.3.0 milestone Aug 9, 2022
@tenthirtyam tenthirtyam added acknowledged Status: Issue or Pull Request Acknowledged area/clustering Area: Clustering size/l Relative Sizing: Large planned labels Aug 9, 2022
tenthirtyam pushed a commit that referenced this issue Aug 25, 2022
Updates `CHANGELOG.md` to include the feature provided in #1727.

Signed-off-by: Ryan Johnson <[email protected]>
tenthirtyam pushed a commit that referenced this issue Aug 25, 2022
Updates `CHANGELOG.md` to include the feature provided in #1727.

Signed-off-by: Ryan Johnson <[email protected]>
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
acknowledged Status: Issue or Pull Request Acknowledged area/clustering Area: Clustering enhancement Type: Enhancement size/l Relative Sizing: Large
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants