feat: Add support vSAN space efficiency #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature is to support configuring the compression and deduplication for vSAN. In this change, we added two new parameters "vsan_dedup_enabled" and "vsan_compression_enabled" to support the toggling of data efficiency configuration for the specified vSAN datastore. The goVmomi version is also updated to support the latest VMODL connection to vSphere/vSAN.
Testing Details:
We did end to end test from 6 standalone hosts based on the vSphere 7.0. A vSAN cluster could be created with deduplication and compression-only enabled by running .tf file which contains the following settings.
```
resource "vsphere_compute_cluster" "cluster" {
name = "clusternemae"
datacenter_id = data.vsphere_datacenter.datacenter.id
vsan_enabled = true
vsan_dedup_enabled = true
vsan_compression_enabled = true
}
```
We can also create a vSAN cluter with compression only by set vsan_compression_enabled true only.
```
resource "vsphere_compute_cluster" "cluster" {
name = "clusternemae"
datacenter_id = data.vsphere_datacenter.datacenter.id
vsan_enabled = true
vsan_dedup_enabled = false
vsan_compression_enabled = true
}
```
Updates the context for `vsan_dedup_enabled` argument and addresses line breaks. Signed-off-by: Ryan Johnson <[email protected]>
github-actions
bot
added
documentation
appilon
added
area/storage
appilon
changed the title
tenthirtyam
approved these changes
Jul 29, 2022
Updates `r/vsphere_compute_cluster` documentation to include a note that you must disable vSphere HA before you enable vSAN on the cluster. Then you can enable / re-enable vSphere HA after vSAN is configured. Signed-off-by: Ryan Johnson <[email protected]>
github-actions
bot
added
documentation
tenthirtyam
changed the title
tenthirtyam
pushed a commit
that referenced
this pull request
Jul 30, 2022
Updates `CHANGELOG.md` to include the feature provided in #1702.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying original PR description from #1683
Please see original PR comments for full context of conversation
Description
This feature is to support configuring the compression and deduplication for vSAN. In this change, we added two new parameters
vsan_dedup_enabledandvsan_compression_enabledto support the toggling of data efficiency configuration for the specified vSAN datastore. Thevmware/govmomiversion is also updated0.28.0to support the latest VMODL connection to vSphere/vSAN.Testing Details:
We did end to end test from 6 standalone hosts based on the vSphere 7.0. A vSAN cluster could be created with deduplication and compression enabled by running .tf file which contains the following settings.
We can also create a vSAN cluster with compression only by only setting
vsan_compression_enabledtotrue.Acceptance tests
Output from acceptance testing:
Release Note
resource/compute_cluster: Add support for vSAN compression and deduplication (GH-1683)References
Closes: #1669