enhance: Allow standby_nics as optional attribute

[tenthirtyam]

Description

Allow standby_nics on r/vsphere_host_virtual_switch to be an optional attribute so the standby_nics = [] does not need to be defined when no standby NICs are required/available.

Release Note

resource/host_virtual_switch: Allow standby_nics on r/vsphere_host_virtual_switch to be an optional attribute so the standby_nics = [] does not need to be defined when no standby NICs are required/available.

References

Closes: #1690

Manual Tests

Current Method:

terraform {
  required_providers {
    vsphere = {
      source  = "local/hashicorp/vsphere"
      version = ">= 2.3.0"
    }
  }
  required_version = ">= 1.2.5"
}

provider "vsphere" {
  vsphere_server       = "m01-vc01.rainpole.io"
  user                 = "[email protected]"
  password             = "VMware1!"
  allow_unverified_ssl = true
}

data "vsphere_datacenter" "datacenter" {
  name = "dc-01"
}

data "vsphere_host" "host" {
  name          = "n-esxi01.rainpole.io"
  datacenter_id = data.vsphere_datacenter.datacenter.id
}

resource "vsphere_host_virtual_switch" "gh-1690" {
  name = "gh-1690"
  host_system_id = data.vsphere_host.host.id
  network_adapters = ["vmnic1","vmnic2","vmnic3"]
  active_nics  =  ["vmnic1"]
  standby_nics = []
}

❯ terraform apply -auto-approve
data.vsphere_datacenter.datacenter: Reading...
data.vsphere_datacenter.datacenter: Read complete after 1s [id=datacenter-99086]
data.vsphere_host.host: Reading...
data.vsphere_host.host: Read complete after 0s [id=host-100004]

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # vsphere_host_virtual_switch.gh-1690 will be created
  + resource "vsphere_host_virtual_switch" "gh-1690" {
      + active_nics              = [
          + "vmnic2",
        ]
      + allow_forged_transmits   = true
      + allow_mac_changes        = true
      + allow_promiscuous        = false
      + beacon_interval          = 1
      + check_beacon             = false
      + failback                 = true
      + host_system_id           = "host-100004"
      + id                       = (known after apply)
      + link_discovery_operation = "listen"
      + link_discovery_protocol  = "cdp"
      + mtu                      = 1500
      + name                     = "gh-1690"
      + network_adapters         = [
          + "vmnic1",
          + "vmnic2",
          + "vmnic3",
        ]
      + notify_switches          = true
      + number_of_ports          = 128
      + shaping_enabled          = false
      + standby_nics             = []
      + teaming_policy           = "loadbalance_srcid"
    }

Plan: 1 to add, 0 to change, 0 to destroy.
vsphere_host_virtual_switch.gh-1690: Creating...
vsphere_host_virtual_switch.gh-1690: Creation complete after 0s [id=tf-HostVirtualSwitch:host-100004:gh-1690]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

Results as expected.

New methods w/ standby_nic optional.

terraform {
  required_providers {
    vsphere = {
      source  = "local/hashicorp/vsphere"
      version = ">= 2.3.0"
    }
  }
  required_version = ">= 1.2.5"
}

provider "vsphere" {
  vsphere_server       = "m01-vc01.rainpole.io"
  user                 = "[email protected]"
  password             = "VMware1!"
  allow_unverified_ssl = true
}

data "vsphere_datacenter" "datacenter" {
  name = "dc-01"
}

data "vsphere_host" "host" {
  name          = "n-esxi01.rainpole.io"
  datacenter_id = data.vsphere_datacenter.datacenter.id
}

resource "vsphere_host_virtual_switch" "gh-1690" {
  name = "gh-1690"
  host_system_id = data.vsphere_host.host.id
  network_adapters = ["vmnic1","vmnic2","vmnic3"]
  active_nics  =  ["vmnic1"]
}

❯ terraform apply -auto-approve
data.vsphere_datacenter.datacenter: Reading...
data.vsphere_datacenter.datacenter: Read complete after 1s [id=datacenter-99086]
data.vsphere_host.host: Reading...
data.vsphere_host.host: Read complete after 0s [id=host-100004]

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # vsphere_host_virtual_switch.gh-1690 will be created
  + resource "vsphere_host_virtual_switch" "gh-1690" {
      + active_nics              = [
          + "vmnic1",
        ]
      + allow_forged_transmits   = true
      + allow_mac_changes        = true
      + allow_promiscuous        = false
      + beacon_interval          = 1
      + check_beacon             = false
      + failback                 = true
      + host_system_id           = "host-100004"
      + id                       = (known after apply)
      + link_discovery_operation = "listen"
      + link_discovery_protocol  = "cdp"
      + mtu                      = 1500
      + name                     = "gh-1690"
      + network_adapters         = [
          + "vmnic1",
          + "vmnic2",
          + "vmnic3",
        ]
      + notify_switches          = true
      + number_of_ports          = 128
      + shaping_enabled          = false
      + teaming_policy           = "loadbalance_srcid"
    }

Plan: 1 to add, 0 to change, 0 to destroy.
vsphere_host_virtual_switch.gh-1690: Creating...
vsphere_host_virtual_switch.gh-1690: Creation complete after 1s [id=tf-HostVirtualSwitch:host-100004:gh-1690]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

Results as expected.

Ryan Johnson
Senior Staff Solutions Architect | Product Engineering @ VMware, Inc.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.