Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update r/vsphere_host docs #1675

Merged
merged 2 commits into from
Jul 15, 2022
Merged

docs: update r/vsphere_host docs #1675

merged 2 commits into from
Jul 15, 2022

Conversation

cwestwater
Copy link
Contributor

@cwestwater cwestwater commented Jun 13, 2022

Description

This is some documentation updates to the resource vsphere_host:

  • Add in the Example Usages section using the data source vsphere_host_thumbprint to get the Host Thumbprint
  • Add a link to the data source vsphere_host_thumbprint in the thumbprint Argument Reference
  • Fix spelling of the word disconnected

I feel adding additional help on getting the thumbprint is important. SSL certs are not often trusted in vSphere, especially at the stage a host is being added to a vCenter. At this point is it not managed by the vSphere Certificate Manager.

Additionally the VMware recommended method of handling certificates is Hybrid mode where the Host certificates are not automatically renewed with a signed certificate.

Release Node

IMPROVEMENTS:

resource/vsphere_host: Documentation updates. (#1675]

References

Add ESXi Host to Cluster with Terraform
New Product Walkthrough – Hybrid vSphere SSL Certificate Replacement

@hashicorp-cla
Copy link

hashicorp-cla commented Jun 13, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added documentation Type: Documentation size/xs Relative Sizing: Extra-Small labels Jun 13, 2022
@tenthirtyam tenthirtyam changed the title Docs/host thumbprint docs: update r/vsphere_host docs Jun 13, 2022
@tenthirtyam tenthirtyam self-requested a review June 13, 2022 19:49
@tenthirtyam tenthirtyam requested a review from appilon June 13, 2022 19:49
@tenthirtyam tenthirtyam added the area/host Area: Host label Jun 13, 2022
@tenthirtyam tenthirtyam added this to the v2.3.0 milestone Jun 13, 2022
@tenthirtyam tenthirtyam added the needs-review Status: Pull Request Needs Review label Jun 15, 2022
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@tenthirtyam tenthirtyam removed the request for review from appilon July 15, 2022 16:28
@tenthirtyam tenthirtyam merged commit f5cb1aa into hashicorp:main Jul 15, 2022
@tenthirtyam tenthirtyam removed the needs-review Status: Pull Request Needs Review label Jul 15, 2022
tenthirtyam pushed a commit that referenced this pull request Jul 15, 2022
Updates `CHANGELOG.md` to include the documentation updates provided in #1675.
@cwestwater cwestwater deleted the docs/host-thumbprint branch July 15, 2022 18:36
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/host Area: Host documentation Type: Documentation size/xs Relative Sizing: Extra-Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants