fix: Prevent unsupported traffic classes to be set and cause crash #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would appear newer versions of vCenter responds back with traffic classes even if those classes aren't accounted in the version of govmomi the provider has. Need to upgrade govmomi to support new `nvmetcp` class that was causing a crash.
github-actions
bot
added
documentation
tenthirtyam
changed the title
tenthirtyam
reviewed
Mar 22, 2022
tenthirtyam
reviewed
Mar 22, 2022
LGTM!
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It would appear newer versions of vCenter responds back with traffic classes
even if those classes aren't accounted in the version of govmomi the provider has.
Need to upgrade govmomi to support new
nvmetcpclass that was causing a crash.Acceptance tests
Release Note
Release note for CHANGELOG:
References