-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vsphere_virtual_machine
resource docs with reboot conditions
#1522
Conversation
* `alternate_guest_name` | ||
* `hardware_version` | ||
* `pci_device_id` | ||
* `memory` - When reducing the memory size, or when increasing the memory size and `memory_hot_add_enabled` is set to `false` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
memory
When reducing or when increasing the memory size and whenmemory_hot_add_enabled
is set tofalse
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think my statement is more correct here as reducing the memory size even if hot add is enabled will cause reboot, but increase the memory size will cause reboot only if hot add is not enabled
* `disk.disk_mode` | ||
* `disk.write_through` | ||
* `disk.disk_sharing` | ||
* `network_interface` - When deleting a network interface and VMware Tools is not running. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
network_interface
When deleting a network interface and VMware Tools is not running.network_interface.adapter_type
When VMware Tools is not running.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's more organised to keep them in one line as the rest of the document, what do you think ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either way is good. 👍🏻
vsphere_virtual_machine
resource docs with reboot conditions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
This functionality has been released in v2.1.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Updated the documentation for vsphere_virtual_machine resource with the conditions that causes the virtual machine to reboot on update.
Acceptance tests
Release Note
Release note for CHANGELOG:
References
Closes #1004