Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vsphere_virtual_machine resource docs with reboot conditions #1522

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

AliAllomani
Copy link
Contributor

@AliAllomani AliAllomani commented Nov 29, 2021

Description

Updated the documentation for vsphere_virtual_machine resource with the conditions that causes the virtual machine to reboot on update.

Acceptance tests

  • Have you added an acceptance test for the functionality being added? Not needed
  • Have you run the acceptance tests on this branch? Not needed

Release Note

Release note for CHANGELOG:

`resource/vsphere_virtual_machine`:  Updated the documentation with the conditions that causes the virtual machine to reboot on update

References

Closes #1004

@github-actions github-actions bot added documentation Type: Documentation size/s Relative Sizing: Small labels Nov 29, 2021
@AliAllomani AliAllomani changed the title updated vm resource doc Update vsphere_virtual_machine resource doc with reboot conditions Nov 29, 2021
* `alternate_guest_name`
* `hardware_version`
* `pci_device_id`
* `memory` - When reducing the memory size, or when increasing the memory size and `memory_hot_add_enabled` is set to `false`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • memory
    When reducing or when increasing the memory size and when memory_hot_add_enabled is set to false.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my statement is more correct here as reducing the memory size even if hot add is enabled will cause reboot, but increase the memory size will cause reboot only if hot add is not enabled

* `disk.disk_mode`
* `disk.write_through`
* `disk.disk_sharing`
* `network_interface` - When deleting a network interface and VMware Tools is not running.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • network_interface
    When deleting a network interface and VMware Tools is not running.
  • network_interface.adapter_type
    When VMware Tools is not running.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's more organised to keep them in one line as the rest of the document, what do you think ?

Copy link
Collaborator

@tenthirtyam tenthirtyam Nov 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way is good. 👍🏻

@tenthirtyam tenthirtyam changed the title Update vsphere_virtual_machine resource doc with reboot conditions Update vsphere_virtual_machine resource docs with reboot conditions Feb 3, 2022
@tenthirtyam tenthirtyam added the needs-review Status: Pull Request Needs Review label Feb 8, 2022
Copy link
Collaborator

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@appilon appilon merged commit e93481d into hashicorp:master Feb 9, 2022
@tenthirtyam tenthirtyam added this to the v2.1.0 milestone Feb 14, 2022
@github-actions
Copy link

github-actions bot commented Mar 2, 2022

This functionality has been released in v2.1.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Type: Documentation size/s Relative Sizing: Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing extra_config results in reboot on apply, even if plan says reboot_required=false
3 participants