Update virtual_machine.html.markdown for the resource.

[tenthirtyam]

Description

Updates virtual_machine.html.markdown for the resource:

• Updated for content accuracy.
• Updated all examples to be more readable and complete.
• Included continuity between examples.
• Addressed concerns mentioned in:
  • Documentation ; vsphere_virtual_machine : disk options conflict #1424
  • Documentation : Dead link in vsphere_virtual_machine network section #1425
  • vApp properties of type 'boolean' behave counter-intuitive #1414
  • Documentation is not clear about required privileges and at which level these should be applied #1356
• Added some clarify based on issues: (re: missing scsi_type)
  • resource vsphere_virtual_machine - ovf_deploy (local) after v1.23.0 removes NIC and default hardware config #1435
  • Deploying ova template results in endless boot loop #1406

Acceptance tests

• Have you added an acceptance test for the functionality being added?
• Have you run the acceptance tests on this branch?
• Not applicable.

Release Note

Release note for CHANGELOG:

Update `vsphere_virtual_machine` resource documenation.

References

• Closes Documentation ; vsphere_virtual_machine : disk options conflict #1424
• Closes Documentation : Dead link in vsphere_virtual_machine network section #1425
• Closes Documentation is not clear about required privileges and at which level these should be applied #1356
• Closes Unclear documentation deploying ovf #1538
• Closes vApp properties of type 'boolean' behave counter-intuitive #1414

[djpbessems]

Perhaps redundant, but I disagree with this PR being satisfactory for closing #1414; the documentation for using boolean vApp properties will be overlooked by end-users and IMHO adding logic to negate predictable user error would be a better approach.

Maybe worth adding; I don't see this as a fault of Terraform or this TF provider, but lacking implementation of the OVF specification on VMware's part.

[tenthirtyam]

I've removed #1414 from the Closes based on above comment.

Ryan

[appilon]

Basically approved!

[tenthirtyam]

Review resolved in 3554978.

[appilon]

@tenthirtyam it claims it can't be merged due to conflicts but isn't mentioning the files.. could you try rebasing with master? I'd recommend squashing this to 1 commit now before trying to get through the merge conflicts so you don't have to resolve it over and over.

[tenthirtyam]

Sure, I just need to recall that command again.

Ryan

[appilon]

I would be happy to do the rebase for you if you don't mind me force pushing over your fork

[tenthirtyam]

Do I get commit credit? 🙃

[appilon]

Haha yes of course!

[tenthirtyam]

Ship it! 🚀

[github-actions]

This functionality has been released in v2.1.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.