Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force reconfigure due to race condition #1486

Merged
merged 2 commits into from
Dec 9, 2021

Conversation

brenthc
Copy link
Contributor

@brenthc brenthc commented Sep 30, 2021

Description

This change removes the conditional logic whereby if the datastore is known, that value is used. In some cases the previously obtained datastore value is incorrect due to an immediate vmotion event that occurs between the initial clone and the post update operations.

Acceptance tests

This issue was observed in production and has been resistant to reproduction due to the numerous factors involved in inducing an immediate vmotion fast enough.

Release Note

Don't assume the datastore is the same between create and post updates

@github-actions github-actions bot added the size/xs Relative Sizing: Extra-Small label Sep 30, 2021
@appilon appilon self-assigned this Dec 6, 2021
Copy link
Contributor

@appilon appilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran some existing tests and it doesn't seem like this change breaks anything so we will give it a shot

@appilon appilon merged commit f5d3b1e into hashicorp:master Dec 9, 2021
@github-actions
Copy link

github-actions bot commented Jan 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2022
@tenthirtyam tenthirtyam added this to the v2.1.0 milestone Feb 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/xs Relative Sizing: Extra-Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants