Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional TTL to data.vault_aws_access_credentials #878

Merged
merged 2 commits into from
Nov 9, 2020
Merged

Add optional TTL to data.vault_aws_access_credentials #878

merged 2 commits into from
Nov 9, 2020

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Oct 14, 2020

Add optional ttl parameter to data.vault_aws_access_credentials data source.

Closes #863

Output from acceptance testing:

$ make testacc TEST=./vault TESTARGS="-run=TestAccDataSourceAWSAccessCredentials"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./vault -v -run=TestAccDataSourceAWSAccessCredentials -timeout 120m
=== RUN   TestAccDataSourceAWSAccessCredentials_basic
--- PASS: TestAccDataSourceAWSAccessCredentials_basic (55.20s)
=== RUN   TestAccDataSourceAWSAccessCredentials_sts
=== RUN   TestAccDataSourceAWSAccessCredentials_sts/sts_without_role_arn
=== RUN   TestAccDataSourceAWSAccessCredentials_sts/sts_with_role_arn
--- PASS: TestAccDataSourceAWSAccessCredentials_sts (4.85s)
    --- PASS: TestAccDataSourceAWSAccessCredentials_sts/sts_without_role_arn (3.00s)
    --- PASS: TestAccDataSourceAWSAccessCredentials_sts/sts_with_role_arn (1.85s)
=== RUN   TestAccDataSourceAWSAccessCredentials_sts_ttl
--- PASS: TestAccDataSourceAWSAccessCredentials_sts_ttl (3.34s)
PASS
ok      github.com/terraform-providers/terraform-provider-vault/vault   63.808s
...

@catsby catsby mentioned this pull request Oct 14, 2020
Closed
@catsby catsby added this to the Future milestone Oct 14, 2020
tomhjp
tomhjp approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@catsby catsby merged commit 27bb268 into master Nov 9, 2020
@catsby catsby deleted the aws_credentials_sts_ttl branch November 9, 2020 21:11
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
@catsby
Add optional TTL to data.vault_aws_access_credentials (hashicorp#878)
b5ec827 
* Add optional TTL to data.vault_aws_access_credentials

* update description
@mechastorm mechastorm mentioned this pull request Feb 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyurik nyurik nyurik left review comments

@tomhjp tomhjp tomhjp approved these changes

Assignees
No one assigned
Labels
documentation size/M
Projects
None yet
Milestone
Future
Development

Successfully merging this pull request may close these issues.

Support TTL with vault_aws_access_credentials
3 participants
@catsby @nyurik @tomhjp