Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vault_ssh_secret_backend_role: add allowed_users_template argument #875

Merged
merged 1 commit into from
Oct 9, 2020
Merged

vault_ssh_secret_backend_role: add allowed_users_template argument #875

merged 1 commit into from
Oct 9, 2020

Conversation

trigrab
Copy link
Contributor

@trigrab trigrab commented Oct 9, 2020 •
edited
Loading

The allowed_users_template option was added to vault in v1.4.0 see (GH-7548)

I oriented this PR to #809 which seemed to be very similar.

Community Note

Release note for CHANGELOG:

resource/vault_ssh_secret_backend_role: Support new `allowed_users_template` argument

Output from acceptance testing:

$ TESTARGS="--run SSHSecretBackendRole" make testacc
...
=== RUN   TestAccSSHSecretBackendRole_basic
--- PASS: TestAccSSHSecretBackendRole_basic (0.48s)
=== RUN   TestAccSSHSecretBackendRoleOTP_basic
--- PASS: TestAccSSHSecretBackendRoleOTP_basic (0.27s)
=== RUN   TestAccSSHSecretBackendRole_import
--- PASS: TestAccSSHSecretBackendRole_import (0.31s)
PASS
...

@trigrab trigrab force-pushed the add-ssh-allowed-users-template branch from 37f020b to f5d139f Compare October 9, 2020 09:51
@trigrab trigrab force-pushed the add-ssh-allowed-users-template branch from f5d139f to 70cd605 Compare October 9, 2020 12:52
catsby
catsby approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@catsby
Copy link
Contributor

catsby commented Oct 9, 2020

Merging despite the failing test; it's unrelated and a known issues

@catsby catsby merged commit 853a47f into hashicorp:master Oct 9, 2020
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
@trigrab
vault_ssh_secret_backend_role: add allowed_users_template argument (h…
d6d2ce2 
…ashicorp#875)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catsby catsby catsby approved these changes

Assignees
No one assigned
Labels
documentation size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support allowed_users_template on vault_ssh_secret_backend_role
2 participants
@trigrab @catsby