add RDS, Aurora and legacy to MySQL backend #87
Conversation
|
Any special reason this PR didn't make it to the release of 1.1.0? |
| Description: "Connection parameters for the mysql-rds-database-plugin plugin.", | ||
| Elem: connectionStringResource(), | ||
| MaxItems: 1, | ||
| ConflictsWith: calculateConflictsWith("mysql-rds", dbBackendTypes), |
There was a problem hiding this comment.
Should be mysql_rds instead of mysql-rds
| Description: "Connection parameters for the mysql-aurora-database-plugin plugin.", | ||
| Elem: connectionStringResource(), | ||
| MaxItems: 1, | ||
| ConflictsWith: calculateConflictsWith("mysql-aurora", dbBackendTypes), |
| Description: "Connection parameters for the mysql-legacy-database-plugin plugin.", | ||
| Elem: connectionStringResource(), | ||
| MaxItems: 1, | ||
| ConflictsWith: calculateConflictsWith("mysql-legacy", dbBackendTypes), |
|
thanks @ShimiTaNaka for the review |
commarla
force-pushed
the
add-mysql-variants
branch
from
b149b84
to
56c1ce4
Compare
|
Any chance of this functionality making it into a release? I'm running up against this now. i.e wanting to use the |
|
@commarla hi! My sincere apologies for the extreme lag in responding to this PR, this repo's care was in transition internally from the Terraform team to the Vault team. This code looks great, thank you for writing it! Would it be possible to add three acceptance tests, one covering each new backend, to |
ghost
added
the
|
@tyrannosaurus-becks Hi, thanks for the review. I've just added the tests. |
add RDS, Aurora and legacy to MySQL backend
Following the official Vault documentation, we should be able to use rds, aurora or legacy MySQL plugins