Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR (#832) #837

Merged
merged 1 commit into from
Jul 31, 2020
Merged

Revert PR (#832) #837

merged 1 commit into from
Jul 31, 2020

Conversation

catsby
Copy link
Contributor

@catsby catsby commented Jul 31, 2020

PR 832 inadvertently introduced issues when the token policy did not
have the required permissions to read the root configuration.

This reverts commit f8b83fb.

Fixes #833

PR 832 inadvertently introduced issues when the token policy did not
have the required permissions to read the root configuration.

This reverts commit f8b83fb.
@ghost ghost added the size/S label Jul 31, 2020
@jasonodonnell jasonodonnell self-requested a review July 31, 2020 14:14
@catsby catsby merged commit c76152c into master Jul 31, 2020
@BonzTM
Copy link

BonzTM commented Jul 31, 2020

@catsby Even with correct permissions, the problem also exists when a region is not provided in root configuration. For example, for those that are using the assumed_role configuration

@jasonodonnell jasonodonnell deleted the revert-832 branch July 31, 2020 14:40
@catsby
Copy link
Contributor Author

catsby commented Jul 31, 2020

Hey @BonzTM - could you possibly share an example configuration that demonstrates what issue you're having? I'm trying to survey the types of issues present here, specifically in v2.12.0 or v2.12.2

@BonzTM
Copy link

BonzTM commented Aug 1, 2020

@catsby I'm sorry, I believe I was just echoing the comment in the open issue at the time. v2.12.0 and v2.12.2 are fine. v2.12.1 has issues when a region is not specified in the core config. Such configurations exist when leveraging the assumed_role configuration of the auth method.

dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
PR 832 inadvertently introduced issues when the token policy did not
have the required permissions to read the root configuration.

This reverts commit f8b83fb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change in v2.12.1
4 participants