new resource: vault_audit #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paultyng
suggested changes
Mar 8, 2018
vault/resource_audit.go
Outdated
| "description": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| Required: false, |
There was a problem hiding this comment.
You don't need to explicitly set the zero values.
vault/resource_audit.go
Outdated
| log.Printf("[DEBUG] Enabling audit backend %s in Vault", path) | ||
|
|
||
| if err := client.Sys().EnableAudit( | ||
| d.Get("path").(string), |
There was a problem hiding this comment.
you already have a path variable above
|
@offlinehacker any plans to make these changes? |
|
@offlinehacker I would like to lend a hand if I could get commit access to your branch? |
offlinehacker
force-pushed
the
feature/resource_vault_audit
branch
from
525ebef
to
0d0b680
Compare
ghost
added
the
|
I created requested changes, also improved test to use stdout, should work now outside docker. |
tyrannosaurus-becks
approved these changes
Sep 13, 2018
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new resource,
vault_audit, which manages vault audit backends. This also solves following issue #53