Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new vault_token_auth_backend_role resource #80

Merged
merged 10 commits into from
Sep 14, 2018

Conversation

martinssipenko
Copy link
Contributor

This PR adds new resource vault_token_auth_backend_role, arguments taken from Vault docs.

@martinssipenko
Copy link
Contributor Author

@paultyng any updates on this?

Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @martinssipenko ! Thanks for submitting this. It looks great. Would you be willing to make that one change and merge in current master? If the tests succeed at that point, I'd be happy to approve this and merge it in. I checked out the acceptance tests and they're all passing.


_, err := client.Logical().Write(path, data)

d.SetId(path)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to move this up above the client.Logical().Write call so the err below gets checked right after the call? Or move it into an if/else for the err?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghost ghost added the size/XL label Sep 14, 2018
@martinssipenko
Copy link
Contributor Author

@tyrannosaurus-becks I've moved the SetId call up a bit as you suggested. Also, I think it's obvious that this provider gets way much less attention than others and if needed I'd be happy to help in any way possible. I think that me and others send PRs here to add missing features and fix bugs as they get found by building infrastructure, and very slow release cycle prevents us from using Terraform, which leads to manual work. It would be great if this could be improved somehow.

@tyrannosaurus-becks tyrannosaurus-becks merged commit 3f40b7f into hashicorp:master Sep 14, 2018
@tyrannosaurus-becks
Copy link
Contributor

@martinssipenko yes, there was about a 6-month period where this provider wasn't getting any attention. It was being shifted from the Terraform team to the Vault team. Apologies! Both teams had a lot of competing projects. It's now resting with me and I'm working through the backlog of PR's and issues. It'll take some time to get caught up, but definitely should be getting better starting now.

dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
Added new vault_token_auth_backend_role resource
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants