-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new vault_token_auth_backend_role resource #80
Conversation
@paultyng any updates on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @martinssipenko ! Thanks for submitting this. It looks great. Would you be willing to make that one change and merge in current master? If the tests succeed at that point, I'd be happy to approve this and merge it in. I checked out the acceptance tests and they're all passing.
|
||
_, err := client.Logical().Write(path, data) | ||
|
||
d.SetId(path) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to move this up above the client.Logical().Write
call so the err below gets checked right after the call? Or move it into an if/else for the err?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tyrannosaurus-becks Done
@tyrannosaurus-becks I've moved the |
@martinssipenko yes, there was about a 6-month period where this provider wasn't getting any attention. It was being shifted from the Terraform team to the Vault team. Apologies! Both teams had a lot of competing projects. It's now resting with me and I'm working through the backlog of PR's and issues. It'll take some time to get caught up, but definitely should be getting better starting now. |
Added new vault_token_auth_backend_role resource
This PR adds new resource
vault_token_auth_backend_role
, arguments taken from Vault docs.