Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: using the right serial_number response key #761

Merged
merged 1 commit into from
May 21, 2020
Merged

fix: using the right serial_number response key #761

merged 1 commit into from
May 21, 2020

Conversation

robsonpeixoto
Copy link
Contributor

@robsonpeixoto robsonpeixoto commented May 19, 2020 •
edited
Loading

The resources below are using the wrong json key and are always returning an empty string:

  • vault_pki_secret_backend_root_cert
  • vault_pki_secret_backend_root_sign_intermediate
  • vault_pki_secret_backend_sign

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

Fix `vault_pki_secret_backend_root_cert`, `vault_pki_secret_backend_root_sign_intermediate` and `vault_pki_secret_backend_sign` to return the right serial number

@ghost ghost added the size/XS label May 19, 2020
@tyrannosaurus-becks tyrannosaurus-becks self-assigned this May 21, 2020
tyrannosaurus-becks
tyrannosaurus-becks approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thank you for fixing this.

@tyrannosaurus-becks tyrannosaurus-becks merged commit 19da15a into hashicorp:master May 21, 2020
@robsonpeixoto
Copy link
Contributor Author

@tyrannosaurus-becks are there plan to release a new version early?

@robsonpeixoto robsonpeixoto deleted the fix/resource_pki_secret_backend_sign-serial branch May 21, 2020 20:31
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
@robsonpeixoto
fix: using the right serial_number response key (hashicorp#761)
d9c25f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyrannosaurus-becks tyrannosaurus-becks tyrannosaurus-becks approved these changes

Assignees

@tyrannosaurus-becks tyrannosaurus-becks

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robsonpeixoto @tyrannosaurus-becks