vault_approle_auth_backend_role: Fix perpetual diff when upgrading from policies to token_policies
#744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
pcman312
approved these changes
May 7, 2020
Merged
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
…om `policies` to `token_policies` (hashicorp#744) * add regression test for hashicorp#533 * conditionally set policies and period
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When upgrading a
vault_approle_auth_backend_rolethat hadpoliciesandperiodspecified but now usestoken_policiesandtoken_period, users could experience a perpetual diff as shown in #533. This specifically effected users on Vault 1.4 and the Vault Terraform provider version 2.7+In this PR we change from always reading
policiesandperiodto only conditionally read them if the user haspoliciesorperiod(respectively) in their configuration. Also adds regression test that demonstrates #533Fixes #533