Add an identity_group_member_entity_ids resource to manage group entity member in a decoupled manner

[shwuandwing]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

make testacc TESTARGS='-run=TestAccIdentityGroup
MemberEntityIdsExclusive'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccIdentityGroupMemberEntityIdsExclusive -timeout 120m
?       github.com/terraform-providers/terraform-provider-vault [no test files]
?       github.com/terraform-providers/terraform-provider-vault/cmd/coverage    [no test files]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-vault/util    (cached) [no tests to run]
=== RUN   TestAccIdentityGroupMemberEntityIdsExclusive
--- PASS: TestAccIdentityGroupMemberEntityIdsExclusive (0.23s)
PASS
ok      github.com/terraform-providers/terraform-provider-vault/vault   0.241s

make testacc TESTARGS='-run=TestAccIdentityGroupMemberEntityIdsNonExclusive'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccIdentityGroupMemberEntityIdsNonExclusive -timeout 12
0m
?       github.com/terraform-providers/terraform-provider-vault [no test files]
?       github.com/terraform-providers/terraform-provider-vault/cmd/coverage    [no test files]
testing: warning: no tests to run
PASS
ok      github.com/terraform-providers/terraform-provider-vault/util    0.009s [no tests to run]
=== RUN   TestAccIdentityGroupMemberEntityIdsNonExclusive
--- PASS: TestAccIdentityGroupMemberEntityIdsNonExclusive (0.33s)
PASS
ok      github.com/terraform-providers/terraform-provider-vault/vault   0.344s
...

[tyrannosaurus-becks]

This looks great so far! Just a couple minor edits and discussion points. Thanks for working on this!

[shwuandwing]

@kalafut -- do you have a timeframe for reviewing this diff?

[austingebauer]

Thanks, @shwuandwing! I'll be taking a look at this PR. Just a couple of small comments to start with.

[austingebauer]

Thanks again, @shwuandwing. I've played around with this new resource for a bit. Things seem to work well overall. Other than a few comments, this change looks good to me 👍

[shwuandwing]

@austingebauer -- let me know if you still want the check for member_entity_ids.

[austingebauer]

LGTM! Thanks for the updates, @shwuandwing.