-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Azure data source that can validate new creds #713
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good! Just minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates look good. I think pulling the sub/tenant/env from the normal config is a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
* add retrying azure data source * Update website/docs/d/azure_access_credentials.html.md Co-Authored-By: Jim Kalafut <[email protected]> * make comment more succinct * update var name, nix unused data * configure client without env vars * fix parameter description * add negative test * support environment, pull vars from config Co-authored-by: Jim Kalafut <[email protected]>
Closes #580
This PR adds a data source for Azure that returns a client ID and secret. By default, these are just returned without testing whether they've fully propagated throughout Azure, which causes Terraform scripts to run quickly. However, by adding the information needed to validate credentials, it defaults to a retrying loop that one of our colleagues has found successful in the past. This retrying loop won't be appropriate for all environments and use cases, so every element of the loop is configurable.
Release note for CHANGELOG:
Output from acceptance testing: