Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vault_cert_auth_backend_role: delete on delete #690

Merged
merged 1 commit into from
Mar 2, 2020
Merged

vault_cert_auth_backend_role: delete on delete #690

merged 1 commit into from
Mar 2, 2020

Conversation

Andor
Copy link
Contributor

@Andor Andor commented Feb 26, 2020

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #575

Release note for CHANGELOG:

Fix vault_cert_auth_backend_role deletion #575

@ghost ghost added the size/XS label Feb 26, 2020
tyrannosaurus-becks
tyrannosaurus-becks approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, small but important fix. Thank you!

@tyrannosaurus-becks tyrannosaurus-becks merged commit 647ad13 into hashicorp:master Mar 2, 2020
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
@Andor
vault_cert_auth_backend_role: delete on delete (hashicorp#690)
dadf0b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyrannosaurus-becks tyrannosaurus-becks tyrannosaurus-becks approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vault_cert_auth_backend_role resource never deletes roles
2 participants
@Andor @tyrannosaurus-becks