Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vault_alicloud_auth_backend_role resource #673

Merged
merged 2 commits into from
Mar 6, 2020

Conversation

lawliet89
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #664

Release note for CHANGELOG:

* Add `vault_alicloud_auth_backend_role` resource

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAlicloudAuthBackendRole'

...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAlicloudAuthBackendRole -timeout 120m
?   	github.com/terraform-providers/terraform-provider-vault	[no test files]
?   	github.com/terraform-providers/terraform-provider-vault/cmd/coverage	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-vault/util	(cached) [no tests to run]
=== RUN   TestAlicloudAuthBackendRole_basic
--- PASS: TestAlicloudAuthBackendRole_basic (0.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-vault/vault	(cached)

@lawliet89
Copy link
Contributor Author

@yongzhang Please give this PR a try if you have the time.

@yongzhang
Copy link

@lawliet89 This is great! Thanks for supporting this!!!

Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for working on this. When we've got the errors lower-cased, should be good to go.

vault/resource_alicloud_auth_backend_role.go Outdated Show resolved Hide resolved
vault/resource_alicloud_auth_backend_role.go Outdated Show resolved Hide resolved
vault/resource_alicloud_auth_backend_role.go Outdated Show resolved Hide resolved
vault/resource_alicloud_auth_backend_role.go Outdated Show resolved Hide resolved
vault/resource_alicloud_auth_backend_role.go Outdated Show resolved Hide resolved
vault/resource_alicloud_auth_backend_role.go Outdated Show resolved Hide resolved
Co-Authored-By: Becca Petrin <[email protected]>
@lawliet89
Copy link
Contributor Author

Made the changes as suggested.

Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! :-) Thank you!

@tyrannosaurus-becks tyrannosaurus-becks merged commit e17b0ca into hashicorp:master Mar 6, 2020
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
* Add `vault_alicloud_auth_backend_role` resource

* Lower case error messages

Co-Authored-By: Becca Petrin <[email protected]>

Co-authored-by: Becca Petrin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add support for vault_alicloud_auth_backend_xxx
3 participants