Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to select AWS ARN from role with multiple configured #661

Merged
merged 4 commits into from
Jan 31, 2020
Merged

Add support to select AWS ARN from role with multiple configured #661

merged 4 commits into from
Jan 31, 2020

Conversation

pcman312
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

Adds ability to choose a specific AWS ARN in vault_aws_access_credentials when a Vault role has multiple ARNs configured.

Output from acceptance testing:

$ TESTARGS="--run DataSourceAWSAccessCredentials --count=1" gnumake testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v --run DataSourceAWSAccessCredentials --count=1 -timeout 120m
?   	github.com/terraform-providers/terraform-provider-vault	[no test files]
?   	github.com/terraform-providers/terraform-provider-vault/cmd/coverage	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-vault/util	0.633s [no tests to run]
=== RUN   TestAccDataSourceAWSAccessCredentials_basic
--- PASS: TestAccDataSourceAWSAccessCredentials_basic (79.31s)
=== RUN   TestAccDataSourceAWSAccessCredentials_sts
=== RUN   TestAccDataSourceAWSAccessCredentials_sts/sts_without_role_arn
=== RUN   TestAccDataSourceAWSAccessCredentials_sts/sts_with_role_arn
--- PASS: TestAccDataSourceAWSAccessCredentials_sts (3.40s)
    --- PASS: TestAccDataSourceAWSAccessCredentials_sts/sts_without_role_arn (1.72s)
    --- PASS: TestAccDataSourceAWSAccessCredentials_sts/sts_with_role_arn (1.68s)
PASS
ok  	github.com/terraform-providers/terraform-provider-vault/vault	83.594s
...

@pcman312
Add ability to select single role_arn
e2ec99f 
When multiple role_arns are specified on a role, this will allow a
single role_arn to be selected.
@pcman312
Improve acceptance test instructions
9f2f844
@ghost ghost added the size/L label Jan 31, 2020
@pcman312 pcman312 requested a review from a team January 31, 2020 18:17
@tyrannosaurus-becks tyrannosaurus-becks self-assigned this Jan 31, 2020
@tyrannosaurus-becks tyrannosaurus-becks removed the request for review from a team January 31, 2020 18:28
tyrannosaurus-becks
tyrannosaurus-becks reviewed Jan 31, 2020
View reviewed changes
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pcman312 , thanks for working on this! It looks great code-wise and test coverage-wise. Just need to also document that field and it'll be ready to go.

P.S., thanks for beefing up the README. :-)

tyrannosaurus-becks
tyrannosaurus-becks suggested changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just requesting changes until the field doc is added.

@ghost ghost added the documentation label Jan 31, 2020
@pcman312 pcman312 merged commit b37b11f into master Jan 31, 2020
@tyrannosaurus-becks tyrannosaurus-becks deleted the select-role_arn branch January 31, 2020 21:12
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
@pcman312
Add support to select AWS ARN from role with multiple configured (has…
8539826 
…hicorp#661)

* Add ability to select single role_arn

When multiple role_arns are specified on a role, this will allow a
single role_arn to be selected.

* Improve acceptance test instructions

* Add acceptance test cost note back

* Update docs to include new  field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyrannosaurus-becks tyrannosaurus-becks tyrannosaurus-becks approved these changes

@kalafut kalafut kalafut approved these changes

Assignees

@tyrannosaurus-becks tyrannosaurus-becks

Labels
documentation size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcman312 @kalafut @tyrannosaurus-becks