Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use set connection_url when available instead of value read for API response for MongoDB plugin #659

Merged
merged 1 commit into from
Feb 4, 2020

Conversation

marceloalmeida
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates And Closes #215

Release note for CHANGELOG:

Use set connection_url when available instead of the value read for the API response for MongoDB

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDatabaseSecretBackendConnection_mongodb'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run=TestAccDatabaseSecretBackendConnection_mongodb -timeout 120m
?   	github.com/terraform-providers/terraform-provider-vault	[no test files]
?   	github.com/terraform-providers/terraform-provider-vault/cmd/coverage	[no test files]
testing: warning: no tests to run
PASS
ok  	github.com/terraform-providers/terraform-provider-vault/util	(cached) [no tests to run]
=== RUN   TestAccDatabaseSecretBackendConnection_mongodb
--- PASS: TestAccDatabaseSecretBackendConnection_mongodb (5.88s)
PASS
ok  	github.com/terraform-providers/terraform-provider-vault/vault

@ghost ghost added the size/XS label Jan 28, 2020
@paulojmdias
Copy link

Awesome 👏

@tyrannosaurus-becks
Copy link
Contributor

tyrannosaurus-becks commented Jan 31, 2020

Hi @marceloalmeida , this PR states that it fixes #215 , but that issue is already closed by another PR. Can you elaborate on the issue you're fixing, with steps to reproduce it?

Also, if it's a permanent diff, will you look at #662 and see if it resolves it for you?

@marceloalmeida
Copy link
Contributor Author

marceloalmeida commented Feb 4, 2020

Hi @tyrannosaurus-becks, this PR states that fixes #215 because the PR #217 does not fix the issue for MongoDB.

Regarding #662 it resolves the issue that this PR also fixes.

Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification! I appreciate your work on this.

@tyrannosaurus-becks tyrannosaurus-becks merged commit 34150fc into hashicorp:master Feb 4, 2020
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vault_database_secret_backend_connection always tries to update connection_url
3 participants