Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GCP secrets credentials on change #635

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Conversation

kalafut
Copy link
Contributor

@kalafut kalafut commented Dec 17, 2019

Fixes #237

@ghost ghost added the size/XS label Dec 17, 2019
@tyrannosaurus-becks tyrannosaurus-becks added this to the 2.8.0 milestone Dec 17, 2019
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thank you!

Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kalafut kalafut merged commit 2f9f282 into master Dec 17, 2019
@kalafut kalafut deleted the fix-gcp-cred-update branch December 17, 2019 22:21
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vault_gcp_secret_backend does not configure vault correctly
3 participants