Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #613 - Add seal_wrap to resource "vault_mount" #616

Conversation

weitzj
Copy link

@weitzj weitzj commented Nov 23, 2019

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #615
Release note for CHANGELOG:

Add support to configure `seal_wrap` for the `resource "vault_mount"` as defined in  https://www.vaultproject.io/api/system/mounts.html#seal_wrap

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestResourceMount_SealWrap'
=== RUN   TestResourceMount_SealWrap
--- PASS: TestResourceMount_SealWrap (0.21s)
...

Info:
I have branched off of tag: v2.6.0. The overall CircleCI tests seem to fail. At least the unit test I have added is working as seen in the logs at: https://circleci.com/gh/terraform-providers/terraform-provider-vault/632?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

Adds support to configure the `seal_wrap` boolean flag
during creating time of a vault_mount as specified in
https://www.vaultproject.io/api/system/mounts.html#seal_wrap

-
hashicorp#615
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thank you so much for adding this.

@tyrannosaurus-becks tyrannosaurus-becks merged commit 1fe70e8 into hashicorp:master Dec 5, 2019
@weitzj weitzj deleted the feature/615-add-seal-wrap branch April 19, 2020 16:29
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
…seal-wrap

Fix hashicorp#613 - Add `seal_wrap` to resource "vault_mount"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add seal_wrap to mount resource
3 participants