Add new k8s auth backend params #601

riuvshyn · 2019-11-11T15:19:17Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

This PR adds new options in Vault k8s auth backend introduced with hashicorp/vault-plugin-auth-kubernetes#70

Release note for CHANGELOG:

Add `issuer` config param to k8s auth backend
Add `audience` param to k8s auth backend role

Output from acceptance testing:

$ make testacc
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v  -timeout 120m
?       github.com/terraform-providers/terraform-provider-vault [no test files]
?       github.com/terraform-providers/terraform-provider-vault/cmd/coverage    [no test files]
=== RUN   TestExpiredTokenError
--- PASS: TestExpiredTokenError (0.00s)
=== RUN   TestSliceHasElement_scalar
--- PASS: TestSliceHasElement_scalar (0.00s)
=== RUN   TestSliceHasElement_struct
--- PASS: TestSliceHasElement_struct (0.00s)
=== RUN   TestSliceAppendIfMissing_scalar
--- PASS: TestSliceAppendIfMissing_scalar (0.00s)
=== RUN   TestSliceAppendIfMissing_struct
--- PASS: TestSliceAppendIfMissing_struct (0.00s)
=== RUN   TestSliceRemoveIfPresent_scalar
--- PASS: TestSliceRemoveIfPresent_scalar (0.00s)
=== RUN   TestSliceRemoveIfPresent_struct
--- PASS: TestSliceRemoveIfPresent_struct (0.00s)
PASS
ok      github.com/terraform-providers/terraform-provider-vault/util    (cached)
=== RUN   TestDataSourceIdentityEntityName
--- PASS: TestDataSourceIdentityEntityName (0.27s)
=== RUN   TestDataSourceIdentityEntityAlias
--- PASS: TestDataSourceIdentityEntityAlias (0.31s)
=== RUN   TestDataSourceIdentityGroupName
--- PASS: TestDataSourceIdentityGroupName (0.27s)
=== RUN   TestDataSourceIdentityGroupAlias
--- PASS: TestDataSourceIdentityGroupAlias (0.30s)
=== RUN   TestAccAppRoleAuthBackendRoleID_basic
--- PASS: TestAccAppRoleAuthBackendRoleID_basic (0.46s)
=== RUN   TestAccAppRoleAuthBackendRoleID_customID
--- PASS: TestAccAppRoleAuthBackendRoleID_customID (0.49s)
=== RUN   TestAccDataSourceAWSAccessCredentials_basic
--- SKIP: TestAccDataSourceAWSAccessCredentials_basic (0.00s)
    provider_test.go:74: AWS_ACCESS_KEY_ID not set
=== RUN   TestAccDataSourceAWSAccessCredentials_sts
--- SKIP: TestAccDataSourceAWSAccessCredentials_sts (0.00s)
    provider_test.go:74: AWS_ACCESS_KEY_ID not set
=== RUN   TestDataSourceGenericSecret
--- PASS: TestDataSourceGenericSecret (0.32s)
=== RUN   TestV2Secret
--- PASS: TestV2Secret (0.65s)
=== RUN   TestAccKubernetesAuthBackendConfigDataSource_basic
--- PASS: TestAccKubernetesAuthBackendConfigDataSource_basic (0.44s)
=== RUN   TestAccKubernetesAuthBackendConfigDataSource_full
--- PASS: TestAccKubernetesAuthBackendConfigDataSource_full (0.45s)
=== RUN   TestAccKubernetesAuthBackendRoleDataSource_basic
--- PASS: TestAccKubernetesAuthBackendRoleDataSource_basic (0.44s)
=== RUN   TestAccKubernetesAuthBackendRoleDataSource_full
--- PASS: TestAccKubernetesAuthBackendRoleDataSource_full (0.46s)
=== RUN   TestDataSourcePolicyDocument
--- SKIP: TestDataSourcePolicyDocument (0.00s)
    data_source_policy_document_test.go:12: this test fails intermittently and needs to be fixed
=== RUN   TestAccAuthBackend_importBasic
--- PASS: TestAccAuthBackend_importBasic (0.24s)
=== RUN   TestAccConsulSecretBackend_import
--- PASS: TestAccConsulSecretBackend_import (0.23s)
=== RUN   TestAccGenericSecret_importBasic
--- PASS: TestAccGenericSecret_importBasic (0.28s)
=== RUN   TestAccMount_importBasic
--- PASS: TestAccMount_importBasic (0.22s)
=== RUN   TestAccPolicy_importBasic
--- PASS: TestAccPolicy_importBasic (0.21s)
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestAccAuthLoginProviderConfigure
--- PASS: TestAccAuthLoginProviderConfigure (0.32s)
=== RUN   TestAccNamespaceProviderConfigure
--- SKIP: TestAccNamespaceProviderConfigure (0.00s)
    provider_test.go:151: TF_ACC_ENTERPRISE is not set, test is applicable only for Enterprise version of Vault
=== RUN   TestAccProviderToken
=== RUN   TestAccProviderToken/None
=== RUN   TestAccProviderToken/File
=== RUN   TestAccProviderToken/CustomHelper
=== RUN   TestAccProviderToken/Schema
--- PASS: TestAccProviderToken (0.01s)
    --- PASS: TestAccProviderToken/None (0.00s)
    --- PASS: TestAccProviderToken/File (0.00s)
    --- PASS: TestAccProviderToken/CustomHelper (0.01s)
    --- PASS: TestAccProviderToken/Schema (0.00s)
=== RUN   TestAccAppRoleAuthBackendLogin_basic
--- PASS: TestAccAppRoleAuthBackendLogin_basic (0.33s)
=== RUN   TestAccAppRoleAuthBackendRoleSecretID_basic
--- PASS: TestAccAppRoleAuthBackendRoleSecretID_basic (0.29s)
=== RUN   TestAccAppRoleAuthBackendRoleSecretID_wrapped
--- PASS: TestAccAppRoleAuthBackendRoleSecretID_wrapped (0.29s)
=== RUN   TestAccAppRoleAuthBackendRoleSecretID_full
--- PASS: TestAccAppRoleAuthBackendRoleSecretID_full (0.29s)
=== RUN   TestAccAppRoleAuthBackendRole_import
--- PASS: TestAccAppRoleAuthBackendRole_import (0.27s)
=== RUN   TestAccAppRoleAuthBackendRole_basic
--- PASS: TestAccAppRoleAuthBackendRole_basic (0.22s)
=== RUN   TestAccAppRoleAuthBackendRole_update
--- PASS: TestAccAppRoleAuthBackendRole_update (0.40s)
=== RUN   TestAccAppRoleAuthBackendRole_full
--- PASS: TestAccAppRoleAuthBackendRole_full (0.25s)
=== RUN   TestAccAppRoleAuthBackendRole_fullUpdate
--- PASS: TestAccAppRoleAuthBackendRole_fullUpdate (0.64s)
=== RUN   TestAccAppRoleAuthBackendRole_deprecatedFullUpdate
--- PASS: TestAccAppRoleAuthBackendRole_deprecatedFullUpdate (0.45s)
=== RUN   TestResourceAudit
--- PASS: TestResourceAudit (0.21s)
=== RUN   TestAuthBackendMigrateState
--- PASS: TestAuthBackendMigrateState (0.00s)
=== RUN   TestResourceAuth
--- PASS: TestResourceAuth (0.34s)
=== RUN   TestAccAWSAuthBackendCert_import
--- PASS: TestAccAWSAuthBackendCert_import (0.27s)
=== RUN   TestAccAWSAuthBackendCert_basic
--- PASS: TestAccAWSAuthBackendCert_basic (0.24s)
=== RUN   TestAccAWSAuthBackendClient_import
--- PASS: TestAccAWSAuthBackendClient_import (0.26s)
=== RUN   TestAccAWSAuthBackendClient_basic
--- PASS: TestAccAWSAuthBackendClient_basic (0.41s)
=== RUN   TestAccAWSAuthBackendClient_nested
--- PASS: TestAccAWSAuthBackendClient_nested (0.38s)
=== RUN   TestAccAWSAuthBackendClient_withoutSecretKey
--- PASS: TestAccAWSAuthBackendClient_withoutSecretKey (0.39s)
=== RUN   TestAccAWSAuthBackendIdentityWhitelist_import
--- PASS: TestAccAWSAuthBackendIdentityWhitelist_import (0.24s)
=== RUN   TestAccAWSAuthBackendIdentityWhitelist_basic
--- PASS: TestAccAWSAuthBackendIdentityWhitelist_basic (0.23s)
=== RUN   TestAccAWSAuthBackendLogin_iamIdentity
--- SKIP: TestAccAWSAuthBackendLogin_iamIdentity (0.00s)
    provider_test.go:74: AWS_ACCESS_KEY_ID not set
=== RUN   TestAccAWSAuthBackendLogin_pkcs7
--- SKIP: TestAccAWSAuthBackendLogin_pkcs7 (0.00s)
    resource_aws_auth_backend_login_test.go:63: Not running on EC2 instance, can't test EC2 auth methods
=== RUN   TestAccAWSAuthBackendLogin_ec2Identity
--- SKIP: TestAccAWSAuthBackendLogin_ec2Identity (0.00s)
    resource_aws_auth_backend_login_test.go:115: Not running on EC2 instance, can't test EC2 auth methods
=== RUN   TestAccAWSAuthBackendRoleTag_basic
--- PASS: TestAccAWSAuthBackendRoleTag_basic (0.26s)
=== RUN   TestAccAWSAuthBackendRole_importInferred
--- PASS: TestAccAWSAuthBackendRole_importInferred (0.31s)
=== RUN   TestAccAWSAuthBackendRole_importEC2
--- PASS: TestAccAWSAuthBackendRole_importEC2 (0.30s)
=== RUN   TestAccAWSAuthBackendRole_importIAM
--- PASS: TestAccAWSAuthBackendRole_importIAM (0.28s)
=== RUN   TestAccAWSAuthBackendRole_inferred
--- PASS: TestAccAWSAuthBackendRole_inferred (0.25s)
=== RUN   TestAccAWSAuthBackendRole_ec2
--- PASS: TestAccAWSAuthBackendRole_ec2 (0.25s)
=== RUN   TestAccAWSAuthBackendRole_iam
--- PASS: TestAccAWSAuthBackendRole_iam (0.25s)
=== RUN   TestAccAWSAuthBackendRole_iam_resolve_aws_unique_ids
--- PASS: TestAccAWSAuthBackendRole_iam_resolve_aws_unique_ids (0.24s)
=== RUN   TestAccAWSAuthBackendRole_iamUpdate
--- PASS: TestAccAWSAuthBackendRole_iamUpdate (0.85s)
=== RUN   TestAccAWSAuthBackendRole_deprecatedEc2
--- PASS: TestAccAWSAuthBackendRole_deprecatedEc2 (0.25s)
=== RUN   TestAccAWSAuthBackendRoleTagBlacklist_import
--- PASS: TestAccAWSAuthBackendRoleTagBlacklist_import (0.26s)
=== RUN   TestAccAWSAuthBackendRoleTagBlacklist_basic
--- PASS: TestAccAWSAuthBackendRoleTagBlacklist_basic (0.23s)
=== RUN   TestAccAWSAuthBackendRoleTagBlacklist_updated
--- PASS: TestAccAWSAuthBackendRoleTagBlacklist_updated (0.54s)
=== RUN   TestAccAWSAuthBackendSTSRole_import
--- PASS: TestAccAWSAuthBackendSTSRole_import (0.26s)
=== RUN   TestAccAWSAuthBackendSTSRole_basic
--- PASS: TestAccAWSAuthBackendSTSRole_basic (0.39s)
=== RUN   TestAccAWSSecretBackendRole_basic
--- SKIP: TestAccAWSSecretBackendRole_basic (0.00s)
    provider_test.go:74: AWS_ACCESS_KEY_ID not set
=== RUN   TestAccAWSSecretBackendRole_import
--- SKIP: TestAccAWSSecretBackendRole_import (0.00s)
    provider_test.go:74: AWS_ACCESS_KEY_ID not set
=== RUN   TestAccAWSSecretBackendRole_nested
--- SKIP: TestAccAWSSecretBackendRole_nested (0.00s)
    provider_test.go:74: AWS_ACCESS_KEY_ID not set
=== RUN   TestAccAWSSecretBackend_basic
--- SKIP: TestAccAWSSecretBackend_basic (0.00s)
    provider_test.go:74: AWS_ACCESS_KEY_ID not set
=== RUN   TestAccAWSSecretBackend_import
--- SKIP: TestAccAWSSecretBackend_import (0.00s)
    provider_test.go:74: AWS_ACCESS_KEY_ID not set
=== RUN   TestAccAzureAuthBackendConfig_import
--- PASS: TestAccAzureAuthBackendConfig_import (0.26s)
=== RUN   TestAccAzureAuthBackendConfig_basic
--- PASS: TestAccAzureAuthBackendConfig_basic (0.37s)
=== RUN   TestAzureAuthBackendRole_basic
--- PASS: TestAzureAuthBackendRole_basic (0.23s)
=== RUN   TestAzureAuthBackendRole
--- PASS: TestAzureAuthBackendRole (0.44s)
=== RUN   TestAzureSecretBackendRole
--- SKIP: TestAzureSecretBackendRole (0.00s)
    resource_azure_secret_backend_role_test.go:18: ARM_SUBSCRIPTION_ID not set
=== RUN   TestAzureSecretBackend
--- PASS: TestAzureSecretBackend (0.24s)
=== RUN   TestCertAuthBackend
--- PASS: TestCertAuthBackend (0.45s)
=== RUN   TestCertAuthBackend_deprecated
--- PASS: TestCertAuthBackend_deprecated (0.24s)
=== RUN   TestConsulSecretBackendRole
--- PASS: TestConsulSecretBackendRole (0.44s)
=== RUN   TestConsulSecretBackendRoleNameFromPath
--- PASS: TestConsulSecretBackendRoleNameFromPath (0.00s)
=== RUN   TestConsulSecretBackendRoleBackendFromPath
--- PASS: TestConsulSecretBackendRoleBackendFromPath (0.00s)
=== RUN   TestConsulSecretBackend
--- PASS: TestConsulSecretBackend (0.38s)
=== RUN   TestAccDatabaseSecretBackendConnection_import
--- SKIP: TestAccDatabaseSecretBackendConnection_import (0.00s)
    resource_database_secret_backend_connection_test.go:17: POSTGRES_URL not set
=== RUN   TestAccDatabaseSecretBackendConnection_cassandra
--- SKIP: TestAccDatabaseSecretBackendConnection_cassandra (0.00s)
    resource_database_secret_backend_connection_test.go:56: CASSANDRA_HOST not set
=== RUN   TestAccDatabaseSecretBackendConnection_mongodb
--- SKIP: TestAccDatabaseSecretBackendConnection_mongodb (0.00s)
    resource_database_secret_backend_connection_test.go:99: MONGODB_URL not set
=== RUN   TestAccDatabaseSecretBackendConnection_mssql
--- SKIP: TestAccDatabaseSecretBackendConnection_mssql (0.00s)
    resource_database_secret_backend_connection_test.go:129: MSSQL_URL not set
=== RUN   TestAccDatabaseSecretBackendConnection_mysql
--- SKIP: TestAccDatabaseSecretBackendConnection_mysql (0.00s)
    resource_database_secret_backend_connection_test.go:162: MYSQL_URL not set
=== RUN   TestAccDatabaseSecretBackendConnectionUpdate_mysql
--- SKIP: TestAccDatabaseSecretBackendConnectionUpdate_mysql (0.00s)
    resource_database_secret_backend_connection_test.go:249: MYSQL_URL not set
=== RUN   TestAccDatabaseSecretBackendConnection_postgresql
--- SKIP: TestAccDatabaseSecretBackendConnection_postgresql (0.00s)
    resource_database_secret_backend_connection_test.go:302: POSTGRES_URL not set
=== RUN   TestAccDatabaseSecretBackendRole_import
--- SKIP: TestAccDatabaseSecretBackendRole_import (0.00s)
    resource_database_secret_backend_role_test.go:17: MYSQL_URL not set
=== RUN   TestAccDatabaseSecretBackendRole_basic
--- SKIP: TestAccDatabaseSecretBackendRole_basic (0.00s)
    resource_database_secret_backend_role_test.go:50: MYSQL_URL not set
=== RUN   TestAccDatabaseSecretBackendStaticRole_import
--- SKIP: TestAccDatabaseSecretBackendStaticRole_import (0.00s)
    resource_database_secret_backend_static_role_test.go:17: MYSQL_URL not set
=== RUN   TestAccDatabaseSecretBackendStaticRole_basic
--- SKIP: TestAccDatabaseSecretBackendStaticRole_basic (0.00s)
    resource_database_secret_backend_static_role_test.go:50: MYSQL_URL not set
=== RUN   TestAccEndpointGoverningPolicy
--- SKIP: TestAccEndpointGoverningPolicy (0.00s)
    resource_egp_policy_test.go:16: TF_ACC_ENTERPRISE is not set, test is applicable only for Enterprise version of Vault
=== RUN   TestGCPAuthBackendRole_basic
--- PASS: TestGCPAuthBackendRole_basic (0.42s)
=== RUN   TestGCPAuthBackendRole_gce
--- PASS: TestGCPAuthBackendRole_gce (0.27s)
=== RUN   TestGCPAuthBackendRole_deprecated
--- PASS: TestGCPAuthBackendRole_deprecated (0.24s)
=== RUN   TestGCPAuthBackend_basic
--- PASS: TestGCPAuthBackend_basic (0.19s)
=== RUN   TestGCPSecretBackend
--- PASS: TestGCPSecretBackend (0.34s)
=== RUN   TestGCPSecretRoleset
--- SKIP: TestGCPSecretRoleset (0.00s)
    provider_test.go:87: GOOGLE_CREDENTIALS not set
=== RUN   TestResourceGenericEndpoint
--- PASS: TestResourceGenericEndpoint (0.45s)
=== RUN   TestGenericSecretMigrateState
--- PASS: TestGenericSecretMigrateState (0.00s)
=== RUN   TestResourceGenericSecret
--- PASS: TestResourceGenericSecret (0.36s)
=== RUN   TestResourceGenericSecret_deleted
--- PASS: TestResourceGenericSecret_deleted (0.41s)
=== RUN   TestAccGithubAuthBackend_basic
--- PASS: TestAccGithubAuthBackend_basic (0.40s)
=== RUN   TestAccGithubAuthBackend_tuning
--- PASS: TestAccGithubAuthBackend_tuning (0.45s)
=== RUN   TestAccGithubAuthBackend_description
--- PASS: TestAccGithubAuthBackend_description (0.40s)
=== RUN   TestAccGithubAuthBackend_importTuning
--- PASS: TestAccGithubAuthBackend_importTuning (0.25s)
=== RUN   TestAccGithubTeam_basic
--- PASS: TestAccGithubTeam_basic (0.40s)
=== RUN   TestAccGithubTeam_teamConfigError
--- PASS: TestAccGithubTeam_teamConfigError (0.02s)
=== RUN   TestAccGithubTeam_importBasic
--- PASS: TestAccGithubTeam_importBasic (0.26s)
=== RUN   TestGithubTeamBackEndPath
=== RUN   TestGithubTeamBackEndPath/With_default_mount
=== RUN   TestGithubTeamBackEndPath/With_custom_mount
--- PASS: TestGithubTeamBackEndPath (0.00s)
    --- PASS: TestGithubTeamBackEndPath/With_default_mount (0.00s)
    --- PASS: TestGithubTeamBackEndPath/With_custom_mount (0.00s)
=== RUN   TestAccGithubUser_basic
--- PASS: TestAccGithubUser_basic (0.43s)
=== RUN   TestAccGithubUser_importBasic
--- PASS: TestAccGithubUser_importBasic (0.30s)
=== RUN   TestGithubUserBackEndPath
=== RUN   TestGithubUserBackEndPath/With_default_mount
=== RUN   TestGithubUserBackEndPath/With_custom_mount
--- PASS: TestGithubUserBackEndPath (0.00s)
    --- PASS: TestGithubUserBackEndPath/With_default_mount (0.00s)
    --- PASS: TestGithubUserBackEndPath/With_custom_mount (0.00s)
=== RUN   TestAccIdentityEntityAlias
--- PASS: TestAccIdentityEntityAlias (0.34s)
=== RUN   TestAccIdentityEntityPoliciesExclusive
--- PASS: TestAccIdentityEntityPoliciesExclusive (0.37s)
=== RUN   TestAccIdentityEntityPoliciesNonExclusive
--- PASS: TestAccIdentityEntityPoliciesNonExclusive (0.24s)
=== RUN   TestAccIdentityEntity
--- PASS: TestAccIdentityEntity (0.20s)
=== RUN   TestAccIdentityEntityUpdate
--- PASS: TestAccIdentityEntityUpdate (0.33s)
=== RUN   TestAccIdentityGroupAlias
--- PASS: TestAccIdentityGroupAlias (0.23s)
=== RUN   TestAccIdentityGroupAliasUpdate
--- PASS: TestAccIdentityGroupAliasUpdate (0.42s)
=== RUN   TestAccidentityGroupPoliciesExclusive
--- PASS: TestAccidentityGroupPoliciesExclusive (0.34s)
=== RUN   TestAccidentityGroupPoliciesNonExclusive
--- PASS: TestAccidentityGroupPoliciesNonExclusive (0.20s)
=== RUN   TestAccIdentityGroup
--- PASS: TestAccIdentityGroup (0.18s)
=== RUN   TestAccIdentityGroupUpdate
--- PASS: TestAccIdentityGroupUpdate (0.52s)
=== RUN   TestAccIdentityGroupExternal
--- PASS: TestAccIdentityGroupExternal (0.19s)
=== RUN   TestAccIdentityOidcKeyAllowedClientId
--- PASS: TestAccIdentityOidcKeyAllowedClientId (0.80s)
=== RUN   TestAccIdentityOidcKey
--- PASS: TestAccIdentityOidcKey (0.57s)
=== RUN   TestAccIdentityOidcKeyUpdate
--- PASS: TestAccIdentityOidcKeyUpdate (0.72s)
=== RUN   TestAccIdentityOidcRole
--- PASS: TestAccIdentityOidcRole (0.47s)
=== RUN   TestAccIdentityOidcRoleUpdate
--- PASS: TestAccIdentityOidcRoleUpdate (0.63s)
=== RUN   TestAccIdentityOidc
--- PASS: TestAccIdentityOidc (0.31s)
=== RUN   TestAccJWTAuthBackendRole_import
--- PASS: TestAccJWTAuthBackendRole_import (0.25s)
=== RUN   TestAccJWTAuthBackendRole_basic
--- PASS: TestAccJWTAuthBackendRole_basic (0.25s)
=== RUN   TestAccJWTAuthBackendRole_update
--- PASS: TestAccJWTAuthBackendRole_update (0.40s)
=== RUN   TestAccJWTAuthBackendRole_full
--- PASS: TestAccJWTAuthBackendRole_full (0.24s)
=== RUN   TestAccJWTAuthBackendRoleOIDC_full
--- PASS: TestAccJWTAuthBackendRoleOIDC_full (1.11s)
=== RUN   TestAccJWTAuthBackendRole_fullUpdate
--- PASS: TestAccJWTAuthBackendRole_fullUpdate (0.43s)
=== RUN   TestAccJWTAuthBackendRole_fullDeprecated
--- PASS: TestAccJWTAuthBackendRole_fullDeprecated (0.40s)
=== RUN   TestAccJWTAuthBackend
--- PASS: TestAccJWTAuthBackend (1.10s)
=== RUN   TestAccJWTAuthBackend_OIDC
--- PASS: TestAccJWTAuthBackend_OIDC (0.38s)
=== RUN   TestAccJWTAuthBackend_negative
--- PASS: TestAccJWTAuthBackend_negative (0.03s)
=== RUN   TestAccJWTAuthBackend_missingMandatory
--- PASS: TestAccJWTAuthBackend_missingMandatory (0.19s)
=== RUN   TestAccKubernetesAuthBackendConfig_import
--- PASS: TestAccKubernetesAuthBackendConfig_import (0.25s)
=== RUN   TestAccKubernetesAuthBackendConfig_basic
--- PASS: TestAccKubernetesAuthBackendConfig_basic (0.21s)
=== RUN   TestAccKubernetesAuthBackendConfig_update
--- PASS: TestAccKubernetesAuthBackendConfig_update (0.38s)
=== RUN   TestAccKubernetesAuthBackendConfig_full
--- PASS: TestAccKubernetesAuthBackendConfig_full (0.22s)
=== RUN   TestAccKubernetesAuthBackendConfig_fullUpdate
--- PASS: TestAccKubernetesAuthBackendConfig_fullUpdate (0.37s)
=== RUN   TestAccKubernetesAuthBackendRole_import
--- PASS: TestAccKubernetesAuthBackendRole_import (0.24s)
=== RUN   TestAccKubernetesAuthBackendRole_basic
--- PASS: TestAccKubernetesAuthBackendRole_basic (0.22s)
=== RUN   TestAccKubernetesAuthBackendRole_update
--- PASS: TestAccKubernetesAuthBackendRole_update (0.36s)
=== RUN   TestAccKubernetesAuthBackendRole_full
--- PASS: TestAccKubernetesAuthBackendRole_full (0.23s)
=== RUN   TestAccKubernetesAuthBackendRole_fullUpdate
--- PASS: TestAccKubernetesAuthBackendRole_fullUpdate (0.67s)
=== RUN   TestAccKubernetesAuthBackendRole_fullDeprecated
--- PASS: TestAccKubernetesAuthBackendRole_fullDeprecated (0.39s)
=== RUN   TestLDAPAuthBackendGroup_import
--- PASS: TestLDAPAuthBackendGroup_import (0.24s)
=== RUN   TestLDAPAuthBackendGroup_basic
--- PASS: TestLDAPAuthBackendGroup_basic (0.22s)
=== RUN   TestLDAPAuthBackend_import
--- PASS: TestLDAPAuthBackend_import (0.24s)
=== RUN   TestLDAPAuthBackend_basic
--- PASS: TestLDAPAuthBackend_basic (0.22s)
=== RUN   TestLDAPAuthBackendUser_import
--- PASS: TestLDAPAuthBackendUser_import (0.27s)
=== RUN   TestLDAPAuthBackendUser_basic
--- PASS: TestLDAPAuthBackendUser_basic (0.23s)
=== RUN   TestMFADuoBasic
--- SKIP: TestMFADuoBasic (0.00s)
    resource_mfa_duo_test.go:17: TF_ACC_ENTERPRISE is not set, test is applicable only for Enterprise version of Vault
=== RUN   TestZeroTTLDoesNotCauseUpdate
--- PASS: TestZeroTTLDoesNotCauseUpdate (0.27s)
=== RUN   TestResourceMount
--- PASS: TestResourceMount (0.35s)
=== RUN   TestResourceMount_Local
--- PASS: TestResourceMount_Local (0.34s)
=== RUN   TestResourceMount_KVV2
--- PASS: TestResourceMount_KVV2 (0.28s)
=== RUN   TestNamespace_basic
--- SKIP: TestNamespace_basic (0.00s)
    resource_namespace_test.go:20: TF_ACC_ENTERPRISE is not set, test is applicable only for Enterprise version of Vault
=== RUN   TestOktaAuthBackendGroup
--- PASS: TestOktaAuthBackendGroup (0.29s)
=== RUN   TestOktaAuthBackend
--- PASS: TestOktaAuthBackend (0.50s)
=== RUN   TestOktaAuthBackendUser
--- PASS: TestOktaAuthBackendUser (0.26s)
=== RUN   TestPkiSecretBackendCert_basic
--- PASS: TestPkiSecretBackendCert_basic (1.76s)
=== RUN   TestPkiSecretBackendCert_renew
--- PASS: TestPkiSecretBackendCert_renew (9.73s)
=== RUN   TestPkiSecretBackendConfigCA_basic
--- PASS: TestPkiSecretBackendConfigCA_basic (0.20s)
=== RUN   TestPkiSecretBackendConfigUrls_basic
--- PASS: TestPkiSecretBackendConfigUrls_basic (0.25s)
=== RUN   TestPkiSecretBackendCrlConfig_basic
--- PASS: TestPkiSecretBackendCrlConfig_basic (4.19s)
=== RUN   TestPkiSecretBackendIntermediateCertRequest_basic
--- PASS: TestPkiSecretBackendIntermediateCertRequest_basic (0.66s)
=== RUN   TestPkiSecretBackendIntermediateSetSigned_basic
--- PASS: TestPkiSecretBackendIntermediateSetSigned_basic (2.93s)
=== RUN   TestPkiSecretBackendRole_basic
--- PASS: TestPkiSecretBackendRole_basic (0.41s)
=== RUN   TestPkiSecretBackendRootCertificate_basic
--- PASS: TestPkiSecretBackendRootCertificate_basic (6.55s)
=== RUN   TestPkiSecretBackendRootSignIntermediate_basic
--- PASS: TestPkiSecretBackendRootSignIntermediate_basic (1.33s)
=== RUN   TestPkiSecretBackendSign_basic
--- PASS: TestPkiSecretBackendSign_basic (3.48s)
=== RUN   TestPkiSecretBackendSign_renew
--- PASS: TestPkiSecretBackendSign_renew (10.83s)
=== RUN   TestPkiSecretBackend_basic
--- PASS: TestPkiSecretBackend_basic (0.33s)
=== RUN   TestPkiSecretBackend_import
--- PASS: TestPkiSecretBackend_import (0.22s)
=== RUN   TestResourcePolicy
--- PASS: TestResourcePolicy (0.29s)
=== RUN   TestAccRabbitmqSecretBackendRole_basic
--- SKIP: TestAccRabbitmqSecretBackendRole_basic (0.00s)
    provider_test.go:107: RMQ_CONNECTION_URI not set
=== RUN   TestAccRabbitmqSecretBackendRole_import
--- SKIP: TestAccRabbitmqSecretBackendRole_import (0.00s)
    provider_test.go:107: RMQ_CONNECTION_URI not set
=== RUN   TestAccRabbitmqSecretBackendRole_nested
--- SKIP: TestAccRabbitmqSecretBackendRole_nested (0.00s)
    provider_test.go:107: RMQ_CONNECTION_URI not set
=== RUN   TestAccRabbitmqSecretBackend_basic
--- SKIP: TestAccRabbitmqSecretBackend_basic (0.00s)
    provider_test.go:107: RMQ_CONNECTION_URI not set
=== RUN   TestAccRabbitmqSecretBackend_import
--- SKIP: TestAccRabbitmqSecretBackend_import (0.00s)
    provider_test.go:107: RMQ_CONNECTION_URI not set
=== RUN   TestAccRoleGoverningPolicy
--- SKIP: TestAccRoleGoverningPolicy (0.00s)
    resource_rgp_policy_test.go:16: TF_ACC_ENTERPRISE is not set, test is applicable only for Enterprise version of Vault
=== RUN   TestAccSSHSecretBackendCA_basic
--- PASS: TestAccSSHSecretBackendCA_basic (1.73s)
=== RUN   TestAccSSHSecretBackendCA_provided
--- PASS: TestAccSSHSecretBackendCA_provided (0.22s)
=== RUN   TestAccSSHSecretBackend_import
--- PASS: TestAccSSHSecretBackend_import (3.53s)
=== RUN   TestAccSSHSecretBackendRole_basic
--- PASS: TestAccSSHSecretBackendRole_basic (0.35s)
=== RUN   TestAccSSHSecretBackendRoleOTP_basic
--- PASS: TestAccSSHSecretBackendRoleOTP_basic (0.21s)
=== RUN   TestAccSSHSecretBackendRole_import
--- PASS: TestAccSSHSecretBackendRole_import (0.24s)
=== RUN   TestAccTokenAuthBackendRoleImport
--- PASS: TestAccTokenAuthBackendRoleImport (0.22s)
=== RUN   TestAccTokenAuthBackendRole
--- PASS: TestAccTokenAuthBackendRole (0.17s)
=== RUN   TestAccTokenAuthBackendRoleUpdate
--- PASS: TestAccTokenAuthBackendRoleUpdate (0.60s)
=== RUN   TestAccTokenAuthBackendRoleDeprecated
--- PASS: TestAccTokenAuthBackendRoleDeprecated (0.33s)
=== RUN   TestResourceToken_basic
--- PASS: TestResourceToken_basic (0.21s)
=== RUN   TestResourceToken_import
--- PASS: TestResourceToken_import (0.25s)
=== RUN   TestResourceToken_full
--- PASS: TestResourceToken_full (0.24s)
=== RUN   TestResourceToken_lookup
--- PASS: TestResourceToken_lookup (0.25s)
=== RUN   TestResourceToken_expire
--- PASS: TestResourceToken_expire (11.70s)
=== RUN   TestResourceToken_renew
--- PASS: TestResourceToken_renew (21.69s)
=== RUN   TestAccTransitCacheConfig
--- PASS: TestAccTransitCacheConfig (0.62s)
=== RUN   TestTransitSecretBackendKey_basic
--- PASS: TestTransitSecretBackendKey_basic (0.50s)
=== RUN   TestTransitSecretBackendKey_rsa4096
--- PASS: TestTransitSecretBackendKey_rsa4096 (5.48s)
=== RUN   TestTransitSecretBackendKey_import
--- PASS: TestTransitSecretBackendKey_import (0.25s)
=== RUN   TestExpandAuthMethodTune
--- PASS: TestExpandAuthMethodTune (0.00s)
=== RUN   TestFlattenAuthMethodTune
--- PASS: TestFlattenAuthMethodTune (0.00s)
=== RUN   TestValidateNoTrailingSlash
--- PASS: TestValidateNoTrailingSlash (0.00s)
PASS
ok      github.com/terraform-providers/terraform-provider-vault/vault   138.638s

cc @tyrannosaurus-becks

vault/data_source_kubernetes_auth_backend_role.go

website/docs/r/kubernetes_auth_backend_role.html.md

seh · 2019-12-04T16:46:47Z

Oh, I'm sorry; I didn't realize that this was just documenting committed changes to the Vault plugin. My comments would have been better suited over there—hashicorp/vault#7509—and much earlier.

tyrannosaurus-becks

This looks fantastic so far! Maybe the tests I'm hoping for are already here but not in view from the PR's changelist, let me know if that's the case. Thanks for your work on this. Couple of minor things and it'll be good to go.

vault/data_source_kubernetes_auth_backend_config_test.go

vault/data_source_kubernetes_auth_backend_role.go

vault/data_source_kubernetes_auth_backend_role_test.go

vault/resource_kubernetes_auth_backend_config.go

vault/resource_kubernetes_auth_backend_config_test.go

vault/resource_kubernetes_auth_backend_role_test.go

website/docs/r/kubernetes_auth_backend_role.html.md

riuvshyn · 2019-12-05T16:05:12Z

@tyrannosaurus-becks hey! thanks for the review! I'll try to get over it soon and add all the missing bits.
🙇

riuvshyn · 2019-12-06T11:53:20Z

@tyrannosaurus-becks heya, I think I've fixed all the concerns, please let me know if I need to do anything else

tyrannosaurus-becks

Fantastic! Thank you so much for doing this.

Add new k8s auth backend params

riuvshyn added 3 commits November 11, 2019 15:58

Adds new k8s auth config param 'issuer'

4d571fd

Adds new k8s auth backend role param 'audience'

2e6737f

Adds documentation for new k8s auth config and role options

c0403ea

ghost added size/L documentation labels Nov 11, 2019

Add removed by accident test field

5e1147b

riuvshyn mentioned this pull request Nov 11, 2019

Add new fields to K8S Auth Documentation hashicorp/vault#7509

Merged

riuvshyn changed the title ~~Add new k8s auth params~~ Add new k8s auth backend params Nov 11, 2019

seh reviewed Dec 4, 2019

View reviewed changes

vault/data_source_kubernetes_auth_backend_role.go Show resolved Hide resolved

website/docs/r/kubernetes_auth_backend_role.html.md Show resolved Hide resolved

seh mentioned this pull request Dec 4, 2019

Add option for specifying the jwt issuer in the configuration. hashicorp/vault-plugin-auth-kubernetes#70

Merged

tyrannosaurus-becks self-assigned this Dec 5, 2019

tyrannosaurus-becks reviewed Dec 5, 2019

View reviewed changes

riuvshyn added 5 commits December 6, 2019 10:43

Merge branch 'master' into add_new_k8s_auth_params

e6c4b01

check if default issuer is set with basic k8s auth basic config

50ad56d

remove audience from k8s auth role basic config

e3e4bcb

do not set issuer by default

ab0e44a

add import test without issuer

6b5077f

tyrannosaurus-becks approved these changes Dec 6, 2019

View reviewed changes

tyrannosaurus-becks merged commit 3c65337 into hashicorp:master Dec 6, 2019

seh mentioned this pull request Jul 18, 2020

propose a way to get service account token for csi driver kubernetes/enhancements#1855

Merged

dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021

Merge pull request hashicorp#601 from riuvshyn/add_new_k8s_auth_params

d07a3fd

Add new k8s auth backend params

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new k8s auth backend params #601

Add new k8s auth backend params #601

riuvshyn commented Nov 11, 2019 •

edited

Loading

seh commented Dec 4, 2019

tyrannosaurus-becks left a comment

riuvshyn commented Dec 5, 2019

riuvshyn commented Dec 6, 2019

tyrannosaurus-becks left a comment

Add new k8s auth backend params #601

Add new k8s auth backend params #601

Conversation

riuvshyn commented Nov 11, 2019 • edited Loading

Community Note

seh commented Dec 4, 2019

tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

riuvshyn commented Dec 5, 2019

riuvshyn commented Dec 6, 2019

tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

riuvshyn commented Nov 11, 2019 •

edited

Loading