Consul secret backend #59
Conversation
- changed path to backend - gave scheme a default value
- passes acceptance tests - incorporated backend name change to path - parameterized the terraform configs a little bit
|
Tests seem to be working now I think. |
|
Is anything on the Vault Terraform provider still active? Nothing has been merged since may 7th. That is more than 2,5 months ago. |
There was a problem hiding this comment.
Hi @draggeta ! Apologies for my slowness in getting to this, I'm just getting ramped up. This code looks great. I ran the acceptance tests and they work. My comment about stripping the field type declaration is a non-blocker. I was just wondering if you could merge in the latest master and push it, and if so, I'd be happy to approve and merge this.
ghost
added
the
|
Hi @tyrannosaurus-becks. Thanks for reviewing it. That was indeed an unnecessary type declaration. Still new to the language. I've removed it and fixed the merge conflicts. Hopefully it's suited now for merging. |
Consul secret backend
To fix one of the issues mentioned in #52, I've created this pull request. The code functions, but there are still some areas I'm unsure of due to lack of knowledge of Go (no prior experience except for PowerShell). It is mostly based on the AWS secret backend resource.
Similar to the AWS secret backend, it mounts the backend as well. This is due to the fact that the configuration cannot be removed once configured. If you want to remove the configuration, the whole mount needs to be removed.
Areas I'm unsure of: