Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing attributes and allow importing on consul_secret_backend_role #581

Merged
merged 8 commits into from
Nov 1, 2019

Conversation

hamishforbes
Copy link
Contributor

Also changes the ID to follow the pattern of other vault resources where the Vault API path is the ID, rather than a comma separated backend,role format.

This breaks backward compatibility, not sure if some kind of migration is required?

Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking fantastic, thanks for working on this. Just a couple of questions here and there.

@ghost ghost added size/XL and removed size/L labels Nov 1, 2019
Copy link
Contributor

@tyrannosaurus-becks tyrannosaurus-becks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Much appreciated.

@tyrannosaurus-becks tyrannosaurus-becks merged commit 02a75df into hashicorp:master Nov 1, 2019
dandandy pushed a commit to dandandy/terraform-provider-vault that referenced this pull request Jun 17, 2021
Add missing attributes and allow importing on consul_secret_backend_role
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants