Add information about Vault 1.2 for token_* fields
#565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashicorp#487 deprecated some fields that were deprecated in Vault 1.2 Add more context to deprecation messages that the new `token_*` fields are only for Vault >= 1.2
ghost
added
|
Would love to see this merged. Would have save us some time when upgrading. |
kalafut
reviewed
Oct 29, 2019
| * `token_period` - (Optional) If set, indicates that the | ||
| token generated using this role should never expire. The token should be renewed within the | ||
| duration specified by this value. At each renewal, the token's TTL will be set to the | ||
| value of this field. The maximum allowed lifetime of token issued using this |
There was a problem hiding this comment.
I think the The maximum allowed lifetime of token issued using this role text is an error (here and in the same block elsewhere.) Looks like that might be an error that predates this PR actually.
There was a problem hiding this comment.
@kalafut I've fixed the text.
kalafut
suggested changes
Oct 29, 2019
martinssipenko
added a commit
to martinssipenko/terraform-provider-vault
that referenced
this pull request
Oct 31, 2019
* master: fix code blocks formatting and vault_azure_secret_* links titles (hashicorp#588) Update CHANGELOG.md Add information about Vault 1.2 for `token_*` fields (hashicorp#565) Fix grammar Add missing docs for `identity_group_policies` Fix missing quote that breaks documentation rendering. repushing Adding sidebar link to crl_config Add whitelines to address hanging "```" Added pull request template
martinssipenko
added a commit
to martinssipenko/terraform-provider-vault
that referenced
this pull request
Oct 31, 2019
* master: fix code blocks formatting and vault_azure_secret_* links titles (hashicorp#588) Update CHANGELOG.md Add information about Vault 1.2 for `token_*` fields (hashicorp#565) Fix grammar Add missing docs for `identity_group_policies` Fix missing quote that breaks documentation rendering. repushing Adding sidebar link to crl_config Add whitelines to address hanging "```"
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
* master: fix code blocks formatting and vault_azure_secret_* links titles (hashicorp#588) Update CHANGELOG.md Add information about Vault 1.2 for `token_*` fields (hashicorp#565) Fix grammar Add missing docs for `identity_group_policies` Fix missing quote that breaks documentation rendering. repushing Adding sidebar link to crl_config Add whitelines to address hanging "```" Added pull request template
dandandy
pushed a commit
to dandandy/terraform-provider-vault
that referenced
this pull request
Jun 17, 2021
* master: fix code blocks formatting and vault_azure_secret_* links titles (hashicorp#588) Update CHANGELOG.md Add information about Vault 1.2 for `token_*` fields (hashicorp#565) Fix grammar Add missing docs for `identity_group_policies` Fix missing quote that breaks documentation rendering. repushing Adding sidebar link to crl_config Add whitelines to address hanging "```"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#487
deprecated some fields that were deprecated in Vault 1.2
Add more context to deprecation messages that the new
token_*fieldsare only for Vault >= 1.2